cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhigg...@apache.org
Subject webworks commit: [CB-4423] Warn when special characters are used in create script
Date Fri, 09 Aug 2013 13:40:03 GMT
Updated Branches:
  refs/heads/master 2936ea0dc -> f102d3f0d


[CB-4423] Warn when special characters are used in create script

The native packager will replace all special characters with underscores.

Reviewed by Jeffrey Heifetz <jheifetz@blackberry.com>


Project: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/commit/f102d3f0
Tree: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/tree/f102d3f0
Diff: http://git-wip-us.apache.org/repos/asf/cordova-blackberry/diff/f102d3f0

Branch: refs/heads/master
Commit: f102d3f0d2cc24d6bcfdb9925a1610e0001418db
Parents: 2936ea0
Author: Danyi Lin <danylin@blackberry.com>
Authored: Wed Aug 7 11:36:14 2013 -0400
Committer: Bryan Higgins <bhiggins@blackberry.com>
Committed: Fri Aug 9 09:39:55 2013 -0400

----------------------------------------------------------------------
 blackberry10/bin/create.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-blackberry/blob/f102d3f0/blackberry10/bin/create.js
----------------------------------------------------------------------
diff --git a/blackberry10/bin/create.js b/blackberry10/bin/create.js
index deee89d..ebba0e2 100644
--- a/blackberry10/bin/create.js
+++ b/blackberry10/bin/create.js
@@ -86,9 +86,8 @@ function validate() {
         process.exit(2);
     }
     if (!validPackageName(app_id)) {
-        console.log("App ID must be sequence of alpha-numeric (optionally seperated by '.')
characters, no longer than 50 characters");
-        help();
-        process.exit(2);
+        console.log("[warning] App ID must be sequence of alpha-numeric (optionally seperated
by '.') characters, no longer than 50 characters.\n" +
+                    "special characters in '" + app_id + "' will be replaced by '_'");
     }
     if (!validBarName(bar_name)) {
         console.log("BAR filename can only contain alpha-numeric, '.', '-' and '_' characters");


Mime
View raw message