cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tim...@apache.org
Subject git commit: [CB-4036] Forgot updated default-engines file
Date Fri, 23 Aug 2013 22:29:06 GMT
Updated Branches:
  refs/heads/engineCheck e911126a6 -> b1da077de


[CB-4036] Forgot updated default-engines file


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/b1da077d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/b1da077d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/b1da077d

Branch: refs/heads/engineCheck
Commit: b1da077dec1d3720f7c1f0cdcec75140110aab7a
Parents: e911126
Author: Tim Kim <timk@adobe.com>
Authored: Fri Aug 23 15:28:58 2013 -0700
Committer: Tim Kim <timk@adobe.com>
Committed: Fri Aug 23 15:28:58 2013 -0700

----------------------------------------------------------------------
 src/util/default-engines.js | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/b1da077d/src/util/default-engines.js
----------------------------------------------------------------------
diff --git a/src/util/default-engines.js b/src/util/default-engines.js
index cdfdfde..ce5f454 100644
--- a/src/util/default-engines.js
+++ b/src/util/default-engines.js
@@ -1,9 +1,5 @@
 var path = require('path');
 
-// wondering how to nicely store paths here...
-// it'd be nice to just point to this file and get the correct path
-// since these scripts should ideally be accessed from the cordova project folder
-
 module.exports = function(project_dir){
     return {
         'cordova': 
@@ -24,22 +20,15 @@ module.exports = function(project_dir){
         'cordova-windows8': 
             { 'platform':'windows8', 'scriptSrc': path.join(project_dir,'cordova','version')
},
         
-        // ideally these sdk versions will be known via a script
-        // that calls the sdk's version command - the idea would be that
-        // these version scripts output all in the same way and parse
-        // the appropriate blob of info returned from the sdk version command
+        // TODO: these scripts have not been made!
         'apple-xcode' : 
-            { 'platform':'ios', 'scriptSrc': '' },
+            { 'platform':'ios', 'scriptSrc':  path.join(project_dir,'cordova','apple-xcode-version')
},
         'apple-ios' : 
-            { 'platform':'ios', 'scriptSrc': '' },
+            { 'platform':'ios', 'scriptSrc': path.join(project_dir,'cordova','apple-ios-version')
},
         'blackberry-webworks' : 
-            // use path to sdk/Framework/lib/webworks-info.js 
-            // will export as version number
-            // currently though, all versions of webworks sdk should be good to go 
-            // so this is technically *not* needed right now
-            { 'platform':'blackberry10', 'scriptSrc': '' },
+            { 'platform':'blackberry10', 'scriptSrc': path.join(project_dir,'blackberry-webworks-version')
},
         'android-sdk' : 
             // will have to parse string output from android list targets
-            { 'platform':'android', 'scriptSrc': '' }
+            { 'platform':'android', 'scriptSrc': path.join(project_dir,'cordova','android-sdk-version')
}
     }
 };


Mime
View raw message