Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5CE810211 for ; Thu, 11 Jul 2013 21:50:02 +0000 (UTC) Received: (qmail 19249 invoked by uid 500); 11 Jul 2013 21:50:02 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 19183 invoked by uid 500); 11 Jul 2013 21:50:02 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 18899 invoked by uid 99); 11 Jul 2013 21:50:01 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jul 2013 21:50:01 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 9C6C28940C9; Thu, 11 Jul 2013 21:50:01 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: anis@apache.org To: commits@cordova.apache.org Date: Thu, 11 Jul 2013 21:50:15 -0000 Message-Id: <0d98fe343050410ea97a53084cdc2f68@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [15/43] git commit: [CB-4016] only write out cordova_plugins.js. [CB-4016] only write out cordova_plugins.js. Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/9c253e1a Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/9c253e1a Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/9c253e1a Branch: refs/heads/plugman-registry Commit: 9c253e1a72156da8fcafc53e31b2852e7fdc805b Parents: f4ffadc Author: Fil Maj Authored: Tue Jul 9 21:06:02 2013 -0700 Committer: Fil Maj Committed: Tue Jul 9 21:06:02 2013 -0700 ---------------------------------------------------------------------- spec/prepare.spec.js | 4 ++-- src/prepare.js | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/9c253e1a/spec/prepare.spec.js ---------------------------------------------------------------------- diff --git a/spec/prepare.spec.js b/spec/prepare.spec.js index 675444a..89db3b5 100644 --- a/spec/prepare.spec.js +++ b/spec/prepare.spec.js @@ -36,9 +36,9 @@ describe('prepare', function() { find:find }); }); - it('should create a cordova_plugins.json file', function() { + it('should NOT create a cordova_plugins.json file', function() { prepare(temp, 'android', plugins_dir); - expect(write).toHaveBeenCalledWith(json, jasmine.any(String), 'utf-8'); + expect(write).not.toHaveBeenCalledWith(json, jasmine.any(String), 'utf-8'); }); it('should create a cordova_plugins.js file', function() { prepare(temp, 'android', plugins_dir); http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/9c253e1a/src/prepare.js ---------------------------------------------------------------------- diff --git a/src/prepare.js b/src/prepare.js index 4904975..f9b755c 100644 --- a/src/prepare.js +++ b/src/prepare.js @@ -123,9 +123,6 @@ module.exports = function handlePrepare(project_dir, platform, plugins_dir) { } }); - require('../plugman').emit('log', 'Writing out cordova_plugins.json...'); - // Write out moduleObjects as JSON to cordova_plugins.json - fs.writeFileSync(path.join(wwwDir, 'cordova_plugins.json'), JSON.stringify(moduleObjects), 'utf-8'); // Write out moduleObjects as JSON wrapped in a cordova module to cordova_plugins.js // This is to support Windows Phone platforms that have trouble with XHR during load var final_contents = "cordova.define('cordova/plugin_list', function(require, exports, module) {\n";