cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabb...@apache.org
Subject git commit: [CB-4090] Broken notification handling
Date Mon, 08 Jul 2013 07:33:42 GMT
Updated Branches:
  refs/heads/master 98e64cd15 -> 8f98831c9


[CB-4090] Broken notification handling


Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/8f98831c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/8f98831c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/8f98831c

Branch: refs/heads/master
Commit: 8f98831c977f15ca867973a794651e679471ea34
Parents: 98e64cd
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Authored: Mon Jul 8 00:31:43 2013 -0700
Committer: Jesse MacFadyen <purplecabbage@gmail.com>
Committed: Mon Jul 8 00:33:16 2013 -0700

----------------------------------------------------------------------
 common/Plugins/Notification.cs | 6 +++---
 wp7/template/config.xml        | 3 +++
 wp8/template/config.xml        | 3 +++
 3 files changed, 9 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/8f98831c/common/Plugins/Notification.cs
----------------------------------------------------------------------
diff --git a/common/Plugins/Notification.cs b/common/Plugins/Notification.cs
index 57262d2..8306ce0 100644
--- a/common/Plugins/Notification.cs
+++ b/common/Plugins/Notification.cs
@@ -106,7 +106,7 @@ namespace WPCordovaClassLib.Cordova.Commands
                     {
                         var previous = notifyBox;
                         notifyBox = new NotificationBox();
-                        notifyBox.Tag = new { previous = previous, callbackId = aliasCurrentCommandCallbackId
};
+                        notifyBox.Tag = new NotifBoxData { previous = previous, callbackId
= aliasCurrentCommandCallbackId };
                         notifyBox.PageTitle.Text = alertOpts.title;
                         notifyBox.SubTitle.Text = alertOpts.message;
                         Button btnOK = new Button();
@@ -148,7 +148,7 @@ namespace WPCordovaClassLib.Cordova.Commands
                     {
                         var previous = notifyBox;
                         notifyBox = new NotificationBox();
-                        notifyBox.Tag = new { previous = previous, callbackId = aliasCurrentCommandCallbackId
};
+                        notifyBox.Tag = new NotifBoxData { previous = previous, callbackId
= aliasCurrentCommandCallbackId };
                         notifyBox.PageTitle.Text = alertOpts.title;
                         notifyBox.SubTitle.Text = alertOpts.message;
 
@@ -242,7 +242,7 @@ namespace WPCordovaClassLib.Cordova.Commands
                 }
 
             }
-            DispatchCommandResult(new PluginResult(PluginResult.Status.OK, retVal),callbackId);
+            DispatchCommandResult(new PluginResult(PluginResult.Status.OK, retVal), callbackId);
         }
 
 

http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/8f98831c/wp7/template/config.xml
----------------------------------------------------------------------
diff --git a/wp7/template/config.xml b/wp7/template/config.xml
index 6ef524c..c8d9cfc 100644
--- a/wp7/template/config.xml
+++ b/wp7/template/config.xml
@@ -79,6 +79,9 @@
     <feature name="InAppBrowser">
       <param name="wp-package" value="InAppBrowser"/>
     </feature>
+    <feature name="Notification">
+      <param name="wp-package" value="Notification"/>
+    </feature>
   </features>
 
 

http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/8f98831c/wp8/template/config.xml
----------------------------------------------------------------------
diff --git a/wp8/template/config.xml b/wp8/template/config.xml
index 6ef524c..c8d9cfc 100644
--- a/wp8/template/config.xml
+++ b/wp8/template/config.xml
@@ -79,6 +79,9 @@
     <feature name="InAppBrowser">
       <param name="wp-package" value="InAppBrowser"/>
     </feature>
+    <feature name="Notification">
+      <param name="wp-package" value="Notification"/>
+    </feature>
   </features>
 
 


Mime
View raw message