cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From i..@apache.org
Subject [5/6] ios commit: [CB-4202] [CB-1107] Remove unit tests for old plugin signature
Date Mon, 15 Jul 2013 16:32:41 GMT
[CB-4202] [CB-1107] Remove unit tests for old plugin signature


Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/8985f6d0
Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/8985f6d0
Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/8985f6d0

Branch: refs/heads/master
Commit: 8985f6d0b9a91d1670c3455a4039020e32b65f65
Parents: a37785b
Author: Ian Clelland <iclelland@chromium.org>
Authored: Mon Jul 15 12:30:13 2013 -0400
Committer: Ian Clelland <iclelland@chromium.org>
Committed: Mon Jul 15 12:31:38 2013 -0400

----------------------------------------------------------------------
 CordovaLibTests/CDVInvokedUrlCommandTests.m | 56 ------------------------
 1 file changed, 56 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/8985f6d0/CordovaLibTests/CDVInvokedUrlCommandTests.m
----------------------------------------------------------------------
diff --git a/CordovaLibTests/CDVInvokedUrlCommandTests.m b/CordovaLibTests/CDVInvokedUrlCommandTests.m
index cdaff0b..b939fc2 100644
--- a/CordovaLibTests/CDVInvokedUrlCommandTests.m
+++ b/CordovaLibTests/CDVInvokedUrlCommandTests.m
@@ -37,62 +37,6 @@
     STAssertEquals([NSArray array], command.arguments, nil);
 }
 
-- (void)testLegacyArgsNoDict
-{
-    NSArray* args = [NSArray arrayWithObjects:@"a", @"b", nil];
-    NSArray* jsonArr = [NSArray arrayWithObjects:@"callbackId", @"className", @"methodName",
args, nil];
-    CDVInvokedUrlCommand* command = [CDVInvokedUrlCommand commandFromJson:jsonArr];
-    NSMutableArray* legacyArgs = nil;
-    NSMutableDictionary* dict = nil;
-
-    [command legacyArguments:&legacyArgs andDict:&dict];
-    // Ensure properties don't change.
-    STAssertEquals(@"callbackId", command.callbackId, nil);
-    STAssertEquals(@"className", command.className, nil);
-    STAssertEquals(@"methodName", command.methodName, nil);
-    STAssertEquals(args, command.arguments, nil);
-
-    NSArray* expected = [NSArray arrayWithObjects:@"callbackId", @"a", @"b", nil];
-    STAssertEqualObjects(expected, legacyArgs, nil);
-    STAssertNil(dict, nil);
-}
-
-- (void)testLegacyArgsWithDicts
-{
-    NSDictionary* dummyDict1 = [NSDictionary dictionaryWithObjectsAndKeys:@"val", @"key",
nil];
-    NSDictionary* dummyDict2 = [NSDictionary dictionaryWithObjectsAndKeys:@"val", @"key",
nil];
-    NSArray* args = [NSArray arrayWithObjects:@"a", dummyDict1, dummyDict2, @"b", nil];
-    NSArray* jsonArr = [NSArray arrayWithObjects:@"callbackId", @"className", @"methodName",
args, nil];
-    CDVInvokedUrlCommand* command = [CDVInvokedUrlCommand commandFromJson:jsonArr];
-    NSMutableArray* legacyArgs = nil;
-    NSMutableDictionary* dict = nil;
-
-    [command legacyArguments:&legacyArgs andDict:&dict];
-    // Ensure properties don't change.
-    STAssertEquals(@"callbackId", command.callbackId, nil);
-    STAssertEquals(@"className", command.className, nil);
-    STAssertEquals(@"methodName", command.methodName, nil);
-    STAssertEquals(args, command.arguments, nil);
-
-    NSArray* expected = [NSArray arrayWithObjects:@"callbackId", @"a", dummyDict2, @"b",
nil];
-    STAssertEqualObjects(expected, legacyArgs, nil);
-    STAssertEqualObjects(dict, dummyDict1, nil);
-}
-
-- (void)testLegacyArgsNoCallbackId
-{
-    NSArray* args = [NSArray arrayWithObjects:@"a", @"b", nil];
-    NSArray* jsonArr = [NSArray arrayWithObjects:[NSNull null], @"className", @"methodName",
args, nil];
-    CDVInvokedUrlCommand* command = [CDVInvokedUrlCommand commandFromJson:jsonArr];
-    NSMutableArray* legacyArgs = nil;
-    NSMutableDictionary* dict = nil;
-
-    [command legacyArguments:&legacyArgs andDict:&dict];
-
-    NSArray* expected = [NSArray arrayWithObjects:@"a", @"b", nil];
-    STAssertEqualObjects(expected, legacyArgs, nil);
-}
-
 - (void)testArgumentAtIndex
 {
     NSArray* jsonArr = [NSArray arrayWithObjects:[NSNull null], @"className", @"methodName",
[NSArray array], nil];


Mime
View raw message