cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [28/50] [abbrv] android commit: CB-3932 Remove baseUrl comment in handleDestroy method made redundant by CB-3766
Date Fri, 28 Jun 2013 16:00:48 GMT
CB-3932 Remove baseUrl comment in handleDestroy method made redundant by CB-3766


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/3a140177
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/3a140177
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/3a140177

Branch: refs/heads/2.9.x
Commit: 3a14017729cacf2464c5e78e0a76c2471ffec0fc
Parents: 4ec3d6d
Author: Angela Fowler <angelaf@fast.au.fujitsu.com>
Authored: Wed Jun 19 15:22:42 2013 +1000
Committer: Angela Fowler <angelaf@fast.au.fujitsu.com>
Committed: Wed Jun 19 15:22:42 2013 +1000

----------------------------------------------------------------------
 framework/src/org/apache/cordova/CordovaWebView.java | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/3a140177/framework/src/org/apache/cordova/CordovaWebView.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaWebView.java b/framework/src/org/apache/cordova/CordovaWebView.java
index e1d1bf1..67775a1 100755
--- a/framework/src/org/apache/cordova/CordovaWebView.java
+++ b/framework/src/org/apache/cordova/CordovaWebView.java
@@ -805,7 +805,6 @@ public class CordovaWebView extends WebView {
     public void handleDestroy()
     {
         // Send destroy event to JavaScript
-    	// Since baseUrl is set in loadUrlIntoView, if user hit Back button before loadUrl was
called, we'll get an NPE on baseUrl (CB-2458)
         this.loadUrl("javascript:try{cordova.require('cordova/channel').onDestroy.fire();}catch(e){console.log('exception
firing destroy event from native');};");
 
         // Load blank page so that JavaScript onunload is called


Mime
View raw message