Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A9465FFAB for ; Fri, 31 May 2013 14:55:38 +0000 (UTC) Received: (qmail 16470 invoked by uid 500); 31 May 2013 14:55:38 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 16411 invoked by uid 500); 31 May 2013 14:55:38 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 16359 invoked by uid 99); 31 May 2013 14:55:36 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 May 2013 14:55:36 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id A0C8B89EAED; Fri, 31 May 2013 14:55:36 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: ian@apache.org To: commits@cordova.apache.org Date: Fri, 31 May 2013 14:55:37 -0000 Message-Id: In-Reply-To: <78e6ef3f0af44ca2a36269abf51deeb2@git.apache.org> References: <78e6ef3f0af44ca2a36269abf51deeb2@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/2] android commit: [CB-3561] Update documentation comments to match implementation [CB-3561] Update documentation comments to match implementation Affects CordovaInterface and CordovaActivity. There should probably be a concerted effort to update this across the entire project. Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/dfb89df4 Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/dfb89df4 Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/dfb89df4 Branch: refs/heads/master Commit: dfb89df4f16104961f6493dfa815909cdfaf51bd Parents: 0e572ae Author: Ian Clelland Authored: Fri May 31 10:38:57 2013 -0400 Committer: Ian Clelland Committed: Fri May 31 10:54:40 2013 -0400 ---------------------------------------------------------------------- .../src/org/apache/cordova/CordovaActivity.java | 6 +----- .../org/apache/cordova/api/CordovaInterface.java | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-android/blob/dfb89df4/framework/src/org/apache/cordova/CordovaActivity.java ---------------------------------------------------------------------- diff --git a/framework/src/org/apache/cordova/CordovaActivity.java b/framework/src/org/apache/cordova/CordovaActivity.java index 4042b6b..b165815 100755 --- a/framework/src/org/apache/cordova/CordovaActivity.java +++ b/framework/src/org/apache/cordova/CordovaActivity.java @@ -64,11 +64,10 @@ import android.widget.LinearLayout; * As an example: * * package org.apache.cordova.examples; - * import android.app.Activity; * import android.os.Bundle; * import org.apache.cordova.*; * - * public class Examples extends DroidGap { + * public class Example extends CordovaActivity { * @Override * public void onCreate(Bundle savedInstanceState) { * super.onCreate(savedInstanceState); @@ -77,9 +76,6 @@ import android.widget.LinearLayout; * super.setStringProperty("loadingDialog", "Title,Message"); // show loading dialog * super.setStringProperty("errorUrl", "file:///android_asset/www/error.html"); // if error loading file in super.loadUrl(). * - * // Initialize activity - * super.init(); - * * // Clear cache if you want * super.appView.clearCache(true); * http://git-wip-us.apache.org/repos/asf/cordova-android/blob/dfb89df4/framework/src/org/apache/cordova/api/CordovaInterface.java ---------------------------------------------------------------------- diff --git a/framework/src/org/apache/cordova/api/CordovaInterface.java b/framework/src/org/apache/cordova/api/CordovaInterface.java index aaa5885..8ef8ed0 100755 --- a/framework/src/org/apache/cordova/api/CordovaInterface.java +++ b/framework/src/org/apache/cordova/api/CordovaInterface.java @@ -24,7 +24,7 @@ import android.content.Intent; import java.util.concurrent.ExecutorService; /** - * The Cordova activity abstract class that is extended by DroidGap. + * The Activity interface that is implemented by CordovaActivity. * It is used to isolate plugin development, and remove dependency on entire Cordova library. */ public interface CordovaInterface {