cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject git commit: adding TODOs
Date Fri, 03 May 2013 02:19:06 GMT
Updated Branches:
  refs/heads/master 0f1426041 -> 747367fb3


adding TODOs


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/747367fb
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/747367fb
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/747367fb

Branch: refs/heads/master
Commit: 747367fb3c3d39697ca8a1371d7a14752a6815d2
Parents: 0f14260
Author: Anis Kadri <anis@apache.org>
Authored: Thu May 2 19:19:00 2013 -0700
Committer: Anis Kadri <anis@apache.org>
Committed: Thu May 2 19:19:00 2013 -0700

----------------------------------------------------------------------
 src/install.js   |    1 +
 src/uninstall.js |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/747367fb/src/install.js
----------------------------------------------------------------------
diff --git a/src/install.js b/src/install.js
index ba9d0bb..bc0e4c5 100644
--- a/src/install.js
+++ b/src/install.js
@@ -134,6 +134,7 @@ function runInstall(platform, project_dir, plugin_dir, plugins_dir, cli_variable
         
         if (err) {
             // FAIL
+            // TODO revert assets at this point too
             if (err. transactions) {
                 handler.uninstall(err.transactions.executed, plugin_id, project_dir, plugin_dir,
function(superr) {
                     var issue = '';

http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/747367fb/src/uninstall.js
----------------------------------------------------------------------
diff --git a/src/uninstall.js b/src/uninstall.js
index 6648e35..e071934 100644
--- a/src/uninstall.js
+++ b/src/uninstall.js
@@ -85,6 +85,7 @@ function runUninstall(platform, project_dir, plugin_dir, plugins_dir, cli_variab
     handler.uninstall(txs, plugin_id, project_dir, plugin_dir, function(err) {
         if (err) {
             // FAIL
+            // TODO revert assets here too
             if (err. transactions) {
                 handler.install(err.transactions.executed, plugin_id, project_dir, plugin_dir,
cli_variables, function(superr) {
                     var issue = '';


Mime
View raw message