cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [05/43] git commit: No <platform> tags for JS-only plugins.
Date Thu, 09 May 2013 23:00:07 GMT
No <platform> tags for JS-only plugins.


Project: http://git-wip-us.apache.org/repos/asf/cordova-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-cli/commit/19d69660
Tree: http://git-wip-us.apache.org/repos/asf/cordova-cli/tree/19d69660
Diff: http://git-wip-us.apache.org/repos/asf/cordova-cli/diff/19d69660

Branch: refs/heads/master
Commit: 19d696600aceb750c4d534f28b36b3494dd6b789
Parents: 10ad93d
Author: Braden Shepherdson <braden.shepherdson@gmail.com>
Authored: Tue Mar 26 16:40:31 2013 -0400
Committer: Braden Shepherdson <braden.shepherdson@gmail.com>
Committed: Tue Mar 26 16:40:31 2013 -0400

----------------------------------------------------------------------
 src/plugin.js |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-cli/blob/19d69660/src/plugin.js
----------------------------------------------------------------------
diff --git a/src/plugin.js b/src/plugin.js
index f2638f5..bbe04b3 100644
--- a/src/plugin.js
+++ b/src/plugin.js
@@ -121,8 +121,10 @@ module.exports = function plugin(command, targets, callback) {
                         else return true;
                     });
 
-                    // Iterate over all matchin app-plugin platforms in the project and uninstall
the
-                    // plugin.
+                    // Iterate over all the common platforms between the plugin
+                    // and the app, and uninstall.
+                    // If this is a web-only plugin with no platform tags, this step
+                    // is not needed and we just --remove the plugin below.
                     var cmd;
                     intersection.forEach(function(platform) {
                         cmd = util.format('%s --platform %s --project "%s" --plugin "%s"
--plugins_dir "%s" --uninstall', cli, platform, path.join(projectRoot, 'platforms', platform),
targetName, path.join(projectRoot, 'plugins'));


Mime
View raw message