Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89E631016B for ; Wed, 24 Apr 2013 16:24:58 +0000 (UTC) Received: (qmail 32098 invoked by uid 500); 24 Apr 2013 16:24:58 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 32082 invoked by uid 500); 24 Apr 2013 16:24:58 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@cordova.apache.org Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 32075 invoked by uid 99); 24 Apr 2013 16:24:58 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Apr 2013 16:24:58 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 1F91A823D63; Wed, 24 Apr 2013 16:24:58 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: agrieve@apache.org To: commits@cordova.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: git commit: Fix exception on install of ios plugin. plistEle is an array. Date: Wed, 24 Apr 2013 16:24:58 +0000 (UTC) Updated Branches: refs/heads/master 9dd8e60ab -> 9f9a4700d Fix exception on install of ios plugin. plistEle is an array. Just taking the first element of it. Not sure if this is the correct fix? Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/9f9a4700 Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/9f9a4700 Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/9f9a4700 Branch: refs/heads/master Commit: 9f9a4700dc36139100eca265fa97061e5f4ce466 Parents: 9dd8e60 Author: Andrew Grieve Authored: Wed Apr 24 12:24:13 2013 -0400 Committer: Andrew Grieve Committed: Wed Apr 24 12:24:13 2013 -0400 ---------------------------------------------------------------------- src/platforms/ios.js | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/9f9a4700/src/platforms/ios.js ---------------------------------------------------------------------- diff --git a/src/platforms/ios.js b/src/platforms/ios.js index 9442c57..9de3750 100644 --- a/src/platforms/ios.js +++ b/src/platforms/ios.js @@ -86,7 +86,7 @@ function handlePlugin(action, plugin_id, txs, project_dir, plugin_dir, variables var projectPListPath = project_plists[0]; // for certain config changes, we need to know if plugins-plist elements are present - var plistEle = txs.filter(function(t) { return t.tag.toLowerCase() == 'plugins-plist'; }); + var plistEle = txs.filter(function(t) { return t.tag.toLowerCase() == 'plugins-plist'; })[0]; var completed = []; while(txs.length) { @@ -145,7 +145,7 @@ function handlePlugin(action, plugin_id, txs, project_dir, plugin_dir, variables if (mod.attrib['target'] == base_config_path) { // edit configuration files var xmlDoc = xml_helpers.parseElementtreeSync(config_file), - pListOnly = plistEle; + pListOnly = !!plistEle; if (mod.find("plugin")) pListOnly = false;