cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject git commit: Fix exception on install of ios plugin. plistEle is an array.
Date Wed, 24 Apr 2013 16:24:58 GMT
Updated Branches:
  refs/heads/master 9dd8e60ab -> 9f9a4700d


Fix exception on install of ios plugin. plistEle is an array.

Just taking the first element of it. Not sure if this is the correct
fix?


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/9f9a4700
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/9f9a4700
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/9f9a4700

Branch: refs/heads/master
Commit: 9f9a4700dc36139100eca265fa97061e5f4ce466
Parents: 9dd8e60
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Wed Apr 24 12:24:13 2013 -0400
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Wed Apr 24 12:24:13 2013 -0400

----------------------------------------------------------------------
 src/platforms/ios.js |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/9f9a4700/src/platforms/ios.js
----------------------------------------------------------------------
diff --git a/src/platforms/ios.js b/src/platforms/ios.js
index 9442c57..9de3750 100644
--- a/src/platforms/ios.js
+++ b/src/platforms/ios.js
@@ -86,7 +86,7 @@ function handlePlugin(action, plugin_id, txs, project_dir, plugin_dir, variables
     var projectPListPath = project_plists[0];
 
     // for certain config changes, we need to know if plugins-plist elements are present
-    var plistEle = txs.filter(function(t) { return t.tag.toLowerCase() == 'plugins-plist';
});
+    var plistEle = txs.filter(function(t) { return t.tag.toLowerCase() == 'plugins-plist';
})[0];
 
     var completed = [];
     while(txs.length) {
@@ -145,7 +145,7 @@ function handlePlugin(action, plugin_id, txs, project_dir, plugin_dir,
variables
                     if (mod.attrib['target'] == base_config_path) {
                         // edit configuration files
                         var xmlDoc = xml_helpers.parseElementtreeSync(config_file),
-                            pListOnly = plistEle;
+                            pListOnly = !!plistEle;
                         
                         if (mod.find("plugin")) pListOnly = false;
 


Mime
View raw message