cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From i..@apache.org
Subject ios commit: [CB-3066] Fire onNativeReady from JS, as bridge is available immediately
Date Thu, 18 Apr 2013 18:25:19 GMT
Updated Branches:
  refs/heads/master ee3580707 -> d8d9f3b3a


[CB-3066] Fire onNativeReady from JS, as bridge is available immediately


Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/d8d9f3b3
Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/d8d9f3b3
Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/d8d9f3b3

Branch: refs/heads/master
Commit: d8d9f3b3a3420d4e0a8597ce8935dfc3f4ba3339
Parents: ee35807
Author: Ian Clelland <iclelland@chromium.org>
Authored: Thu Apr 18 14:18:45 2013 -0400
Committer: Ian Clelland <iclelland@chromium.org>
Committed: Thu Apr 18 14:25:00 2013 -0400

----------------------------------------------------------------------
 CordovaLib/Classes/CDVViewController.m |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/d8d9f3b3/CordovaLib/Classes/CDVViewController.m
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/CDVViewController.m b/CordovaLib/Classes/CDVViewController.m
index 459ef87..94f4552 100644
--- a/CordovaLib/Classes/CDVViewController.m
+++ b/CordovaLib/Classes/CDVViewController.m
@@ -615,12 +615,6 @@
     // It's safe to release the lock even if this is just a sub-frame that's finished loading.
     [CDVUserAgentUtil releaseLock:&_userAgentLockToken];
 
-    // The .onNativeReady().fire() will work when cordova.js is already loaded.
-    // The _nativeReady = true; is used when this is run before cordova.js is loaded.
-    NSString* nativeReady = @"try{cordova.require('cordova/channel').onNativeReady.fire();}catch(e){window._nativeReady
= true;}";
-    // Don't use [commandDelegate evalJs] here since it relies on cordova.js being loaded
already.
-    [self.webView stringByEvaluatingJavaScriptFromString:nativeReady];
-
     /*
      * Hide the Top Activity THROBBER in the Battery Bar
      */


Mime
View raw message