Return-Path: X-Original-To: apmail-cordova-commits-archive@www.apache.org Delivered-To: apmail-cordova-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 74807E918 for ; Fri, 18 Jan 2013 19:54:05 +0000 (UTC) Received: (qmail 62280 invoked by uid 500); 18 Jan 2013 19:54:05 -0000 Delivered-To: apmail-cordova-commits-archive@cordova.apache.org Received: (qmail 62263 invoked by uid 500); 18 Jan 2013 19:54:05 -0000 Mailing-List: contact commits-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@cordova.apache.org Delivered-To: mailing list commits@cordova.apache.org Received: (qmail 62256 invoked by uid 99); 18 Jan 2013 19:54:05 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jan 2013 19:54:05 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 26C9A81F6FF; Fri, 18 Jan 2013 19:54:05 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: agrieve@apache.org To: commits@cordova.apache.org X-Mailer: ASF-Git Admin Mailer Subject: ios commit: Add a code comment that points to the PDF/User-Agent JIRA issue. Message-Id: <20130118195405.26C9A81F6FF@tyr.zones.apache.org> Date: Fri, 18 Jan 2013 19:54:05 +0000 (UTC) Updated Branches: refs/heads/master bcc90d23c -> 0b3934fcd Add a code comment that points to the PDF/User-Agent JIRA issue. Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/0b3934fc Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/0b3934fc Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/0b3934fc Branch: refs/heads/master Commit: 0b3934fcdde9570b2b1b1319b1f137072511ac04 Parents: bcc90d2 Author: Andrew Grieve Authored: Fri Jan 18 14:53:27 2013 -0500 Committer: Andrew Grieve Committed: Fri Jan 18 14:53:27 2013 -0500 ---------------------------------------------------------------------- CordovaLib/Classes/CDVInAppBrowser.m | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/0b3934fc/CordovaLib/Classes/CDVInAppBrowser.m ---------------------------------------------------------------------- diff --git a/CordovaLib/Classes/CDVInAppBrowser.m b/CordovaLib/Classes/CDVInAppBrowser.m index 3e1beea..6d7b770 100644 --- a/CordovaLib/Classes/CDVInAppBrowser.m +++ b/CordovaLib/Classes/CDVInAppBrowser.m @@ -452,7 +452,9 @@ // their start-up flow. // 2. That the PDF does not require any additional network requests. We change // the user-agent here back to that of the CDVViewController, so requests - // from it must pass through its white-list. + // from it must pass through its white-list. This *does* break PDFs that + // contain links to other remote PDF/websites. + // More info at https://issues.apache.org/jira/browse/CB-2225 if (_isPDF) { [CDVUserAgentUtil setUserAgent:_prevUserAgent]; }