cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject ios commit: Add a code comment that points to the PDF/User-Agent JIRA issue.
Date Fri, 18 Jan 2013 19:54:05 GMT
Updated Branches:
  refs/heads/master bcc90d23c -> 0b3934fcd


Add a code comment that points to the PDF/User-Agent JIRA issue.


Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/0b3934fc
Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/0b3934fc
Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/0b3934fc

Branch: refs/heads/master
Commit: 0b3934fcdde9570b2b1b1319b1f137072511ac04
Parents: bcc90d2
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Fri Jan 18 14:53:27 2013 -0500
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Fri Jan 18 14:53:27 2013 -0500

----------------------------------------------------------------------
 CordovaLib/Classes/CDVInAppBrowser.m |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/0b3934fc/CordovaLib/Classes/CDVInAppBrowser.m
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/CDVInAppBrowser.m b/CordovaLib/Classes/CDVInAppBrowser.m
index 3e1beea..6d7b770 100644
--- a/CordovaLib/Classes/CDVInAppBrowser.m
+++ b/CordovaLib/Classes/CDVInAppBrowser.m
@@ -452,7 +452,9 @@
     //    their start-up flow.
     // 2. That the PDF does not require any additional network requests. We change
     //    the user-agent here back to that of the CDVViewController, so requests
-    //    from it must pass through its white-list.
+    //    from it must pass through its white-list. This *does* break PDFs that
+    //    contain links to other remote PDF/websites.
+    // More info at https://issues.apache.org/jira/browse/CB-2225
     if (_isPDF) {
         [CDVUserAgentUtil setUserAgent:_prevUserAgent];
     }


Mime
View raw message