cordova-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agri...@apache.org
Subject [2/4] ios commit: Have the InAppBrowser not use a GUID in its UA.
Date Fri, 23 Nov 2012 02:38:31 GMT
Have the InAppBrowser not use a GUID in its UA.

There's no advantage to doing so that I can think of.


Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/0447deb2
Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/0447deb2
Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/0447deb2

Branch: refs/heads/master
Commit: 0447deb2aef02abd7661c5b022ae233029ad0871
Parents: e8a7401
Author: Andrew Grieve <agrieve@chromium.org>
Authored: Thu Nov 22 21:34:20 2012 -0500
Committer: Andrew Grieve <agrieve@chromium.org>
Committed: Thu Nov 22 21:34:20 2012 -0500

----------------------------------------------------------------------
 CordovaLib/Classes/CDVInAppBrowser.m |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/0447deb2/CordovaLib/Classes/CDVInAppBrowser.m
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/CDVInAppBrowser.m b/CordovaLib/Classes/CDVInAppBrowser.m
index 227ab9a..577c825 100644
--- a/CordovaLib/Classes/CDVInAppBrowser.m
+++ b/CordovaLib/Classes/CDVInAppBrowser.m
@@ -81,14 +81,8 @@
 {
     if (self.inAppBrowserViewController == nil) {
         NSString* originalUA = [CDVViewController originalUserAgent];
+        self.inAppBrowserViewController = [[CDVInAppBrowserViewController alloc] initWithUserAgent:originalUA];
 
-        CFUUIDRef uuidRef = CFUUIDCreate(kCFAllocatorDefault);
-        CFStringRef uuidString = CFUUIDCreateString(kCFAllocatorDefault, uuidRef);
-        NSString* modifiedUA = [NSString stringWithFormat:@"%@ (%@)", originalUA, uuidString];
-        CFRelease(uuidString);
-        CFRelease(uuidRef);
-
-        self.inAppBrowserViewController = [[CDVInAppBrowserViewController alloc] initWithUserAgent:modifiedUA];
         if ([self.viewController conformsToProtocol:@protocol(CDVScreenOrientationDelegate)])
{
             self.inAppBrowserViewController.orientationDelegate = (UIViewController <CDVScreenOrientationDelegate>*)self.viewController;
         }


Mime
View raw message