continuum-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marica Tan <marica....@gmail.com>
Subject Re: Distributed ant
Date Thu, 20 May 2010 23:41:55 GMT
I think this will get fixed by Gwen's patch for CONTINUUM-2454.

I'm just waiting for his changes on the selenium tests before committing it
to trunk.


Thanks,
--
Marica

On Thu, May 20, 2010 at 10:27 PM, Alf Potgieter <AlfP@discovery.co.za>wrote:

> I fixed it locally, from what I can make out 1.3.6 works the same. It
> populates the maven project information in the context before checking if it
> should build.
> The check (somewhere over in a distributed client server master or
> something) only uses the maven info if it is a maven build, so ignoring it
> if there is no project is ok.
>
> I will be trying 1.3.6 as well
>
> alf
>
> diff -Naur
> core/org/apache/continuum/buildagent/taskqueue/execution/BuildProjectTaskExecutor.java
> core-patched/org/apache/continuum/buildagent/taskqueue/execution/BuildProjectTaskExecutor.java
> ---
> core/org/apache/continuum/buildagent/taskqueue/execution/BuildProjectTaskExecutor.java
>      2009-08-24 14:51:54.000000000 +0000
> +++
> core-patched/org/apache/continuum/buildagent/taskqueue/execution/BuildProjectTaskExecutor.java
>      2010-05-20 14:18:02.000000000 +0000
> @@ -514,11 +514,13 @@
>
>             MavenProject project = buildExecutor.getMavenProject(
> workingDirectory, buildDefinition );
>
> -            mavenProject.put( ContinuumBuildAgentUtil.KEY_PROJECT_VERSION,
> project.getVersion() );
> -
> -            if ( project.getModules() != null )
> +            if (project !=null )
>             {
> -                mavenProject.put(
> ContinuumBuildAgentUtil.KEY_PROJECT_MODULES, project.getModules() );
> +                mavenProject.put(
> ContinuumBuildAgentUtil.KEY_PROJECT_VERSION, project.getVersion() );
> +                if ( project.getModules() != null )
> +                {
> +                    mavenProject.put(
> ContinuumBuildAgentUtil.KEY_PROJECT_MODULES, project.getModules() );
> +                }
>             }
>         }
>         catch ( ContinuumAgentBuildExecutorException e )
>
>
>
> -----Original Message-----
> From: Wendy Smoak [mailto:wsmoak@gmail.com]
> Sent: Thursday 20 May 2010 15:57
> To: users@continuum.apache.org
> Subject: Re: Distributed ant
>
> On Thu, May 20, 2010 at 5:03 AM, Alf Potgieter <AlfP@discovery.co.za>
> wrote:
> > Has anyone managed to do a distributed continuum build using ant? I'm
> using continuum 1.3.4 and nothing happens.
>
> I've never tried it, but we'll need more information about how you're
> configuring it in order to help.  It would also be good to try 1.3.6
> just in cased something changed.
>
> (Regardless, it should not be throwing a NPE at you, so there is a bug
> somewhere.)
>
> --
> Wendy
> Discovery Holdings Limited
>
> Registration number: 1999/007789/06
>
> This message and any attachments are confidential and intended solely for
> the addressee. If you have received this message in error, please notify
> Discovery immediately, telephone number +27 11 529 2888. Any unauthorised
> use; alteration or dissemination of the contents of this email is strictly
> prohibited. In no event will Discovery or the sender be liable in any manner
> whatsoever to any person for any loss or any direct, indirect, special or
> consequential damages arising from use of this email or any linked website,
> including, without limitation, from any lost profits, business interruption,
> loss of programmes or other data that may be stored on any information
> handling system or otherwise from any assurance that this email is virus
> free even if Discovery is expressly advised of the possibility of such
> damages. Discovery is an Authorised Financial Services Provider. A full list
> of directors is available on our website at
>
> https://www.discovery.co.za/index_login.jhtml?p_content=/investor_relations/directorate.jhtmlalternatively,
to obtain a full list of Directors via email, please email
> directors_list@discovery.co.za
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message