Return-Path: X-Original-To: apmail-continuum-issues-archive@www.apache.org Delivered-To: apmail-continuum-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 76D2C1084D for ; Thu, 22 Jan 2015 20:16:43 +0000 (UTC) Received: (qmail 89299 invoked by uid 500); 22 Jan 2015 20:16:43 -0000 Delivered-To: apmail-continuum-issues-archive@continuum.apache.org Received: (qmail 89266 invoked by uid 500); 22 Jan 2015 20:16:43 -0000 Mailing-List: contact issues-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list issues@continuum.apache.org Received: (qmail 89255 invoked by uid 99); 22 Jan 2015 20:16:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jan 2015 20:16:43 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [199.193.192.100] (HELO codehaus01.managed.contegix.com) (199.193.192.100) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jan 2015 20:16:38 +0000 Received: from codehaus01 (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id 1EF22B1166 for ; Thu, 22 Jan 2015 14:16:18 -0600 (CST) Date: Thu, 22 Jan 2015 14:16:18 -0600 (CST) From: "Brent N Atkinson (JIRA)" To: issues@continuum.apache.org Message-ID: In-Reply-To: References: Subject: [jira] (CONTINUUM-2723) Edit button does not work - generates internal error MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 22cf62d5d84cf5bea94eb3b65e0ebd09 X-Virus-Checked: Checked by ClamAV on apache.org [ https://jira.codehaus.org/browse/CONTINUUM-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=361655#comment-361655 ] Brent N Atkinson edited comment on CONTINUUM-2723 at 1/22/15 2:15 PM: ---------------------------------------------------------------------- It appears the problem is the dynamic-attributes.ftl template in struts2-core: {code} <#if (parameters.dynamicAttributes?? && parameters.dynamicAttributes?size > 0)><#rt/> <#assign aKeys = parameters.dynamicAttributes.keySet()><#rt/> <#list aKeys as aKey><#rt/> <#assign keyValue = parameters.dynamicAttributes[aKey]/> <#if keyValue?is_string> <#assign value = struts.translateVariables(keyValue)!keyValue/> <#else> <#assign value = keyValue?string/> ${aKey}="${value?html}"<#rt/> <#rt/> <#rt/> {code} When the dynamic attribute map contains the key 'size', this assignment: {code} keyValue = parameters.dynamicAttributes[aKey] {code} Yields a method, and not the value for the key. The reason is that the bean is wrapped and by default, method names shadow the contained map values. It is possible that this can be fixed by changing the template to look something like the following: {code} keyValue = parameters.dynamicAttributes.get(aKey) {code} was (Author: batkinson): It appears the problem is the dynamic-attributes.ftl template in struts2-core: {code} <#if (parameters.dynamicAttributes?? && parameters.dynamicAttributes?size > 0)><#rt/> <#assign aKeys = parameters.dynamicAttributes.keySet()><#rt/> <#list aKeys as aKey><#rt/> <#assign keyValue = parameters.dynamicAttributes[aKey]/> <#if keyValue?is_string> <#assign value = struts.translateVariables(keyValue)!keyValue/> <#else> <#assign value = keyValue?string/> ${aKey}="${value?html}"<#rt/> <#rt/> <#rt/> {code} When the dynamic attribute maps contains the key 'size', this assignment: {code} keyValue = parameters.dynamicAttributes[aKey] {code} Yields a method, and not the value for the key. The reason is that the bean is wrapped and by default, method names shadow the contained map values. It is possible that this can be fixed by changing the template to look something like the following: {code} keyValue = parameters.dynamicAttributes.get(aKey) {code} > Edit button does not work - generates internal error > ---------------------------------------------------- > > Key: CONTINUUM-2723 > URL: https://jira.codehaus.org/browse/CONTINUUM-2723 > Project: Continuum > Issue Type: Bug > Affects Versions: 1.4.2 > Environment: https://continuum-ci.apache.org/continuum/projectView.action?projectId=107 > Reporter: SebbASF > Priority: Blocker > > Press Edit button under the project summary, and Continuum responds with: > https://continuum-ci.apache.org/continuum/httpError.action?errorCode=500 > The URL requested results in an internal error. > It does not appear to be possible to edit the project. > I think this started happening a while back after a security fix was added. -- This message was sent by Atlassian JIRA (v6.1.6#6162)