Mailing-List: contact issues-help@continuum.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@continuum.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Date: Tue, 27 Nov 2012 20:58:13 -0600 (CST)
From: "Brett Porter (JIRA)" <jira@codehaus.org>
To: issues@continuum.apache.org
Message-ID: 
 <1380031151.15527.1354071493887.JavaMail.j2ee-jira@codehaus01.managed.contegix.com>
In-Reply-To: 
 <1330873957.13164.1353574393673.JavaMail.j2ee-jira@codehaus01.managed.contegix.com>
Subject: [jira] (CONTINUUM-2693) File handle leak with TCP connections in
 CLOSE_WAIT when using distributed builds
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit


    [ https://jira.codehaus.org/browse/CONTINUUM-2693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=314521#comment-314521 ] 

Brett Porter commented on CONTINUUM-2693:
-----------------------------------------

went with option #2. The JDK URL connection could well have had other impacts. 

While just setting the connection manager to close after each request, went with the multi-threaded manager which should manage the connections efficiently, even if a couple remain open.

Note that there are other occasions where sockets are left open (e.g. AbstractContinuumProjectBuilder, which has its own httpclient v4). Unifying the HTTP clients used would be beneficial in future, but is best evaluated if the XMLRPC layer gets replaced with something else.
                
> File handle leak with TCP connections in CLOSE_WAIT when using distributed builds
> ---------------------------------------------------------------------------------
>
>                 Key: CONTINUUM-2693
>                 URL: https://jira.codehaus.org/browse/CONTINUUM-2693
>             Project: Continuum
>          Issue Type: Bug
>    Affects Versions: 1.4.1
>            Reporter: Brett Porter
>            Assignee: Brett Porter
>             Fix For: 1.4.1
>
>
> If you generate a lot of requests using the XMLRPC layer, such as when distributed builds are active, it is possible for connections to stay in the {{CLOSE_WAIT}} state until they are garbage collected. On a busy server with the default file limits, this can result in a {{IOException: Too many open files}} error.
> The workaround is to increase the limit of the files for the user running Continuum. However, the XMLRPC layer should manage the connections better to avoid them getting into this state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira