From issues-return-5891-apmail-continuum-issues-archive=continuum.apache.org@continuum.apache.org Sun Jun 12 23:10:10 2011 Return-Path: X-Original-To: apmail-continuum-issues-archive@www.apache.org Delivered-To: apmail-continuum-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C26E434C for ; Sun, 12 Jun 2011 23:10:10 +0000 (UTC) Received: (qmail 65873 invoked by uid 500); 12 Jun 2011 23:10:10 -0000 Delivered-To: apmail-continuum-issues-archive@continuum.apache.org Received: (qmail 65823 invoked by uid 500); 12 Jun 2011 23:10:10 -0000 Mailing-List: contact issues-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list issues@continuum.apache.org Received: (qmail 65815 invoked by uid 99); 12 Jun 2011 23:10:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jun 2011 23:10:09 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com) (63.246.2.115) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jun 2011 23:10:04 +0000 Received: from codehaus01.managed.contegix.com (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id 990CC14A8046 for ; Sun, 12 Jun 2011 18:09:42 -0500 (CDT) Date: Sun, 12 Jun 2011 18:09:42 -0500 (CDT) From: "Maria Catherine Tan (JIRA)" To: issues@continuum.apache.org Message-ID: <25431493.397.1307920182624.JavaMail.haus-jira@codehaus01.managed.contegix.com> In-Reply-To: <33436825.1232485999658.JavaMail.haus-jira@codehaus01.managed.contegix.com> Subject: [jira] Commented: (CONTINUUM-2044) Build agent should only accept requests from its master MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 4e90ceb663894a42f12c0e28abbab431 X-Virus-Checked: Checked by ClamAV on apache.org [ http://jira.codehaus.org/browse/CONTINUUM-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=270228#comment-270228 ] Maria Catherine Tan commented on CONTINUUM-2044: ------------------------------------------------ The key will be saved in the database and in configuration files that's why I thought of encrypting it. But if it's unnecessary I could remove it. > Build agent should only accept requests from its master > ------------------------------------------------------- > > Key: CONTINUUM-2044 > URL: http://jira.codehaus.org/browse/CONTINUUM-2044 > Project: Continuum > Issue Type: Improvement > Components: Distributed Builds > Affects Versions: 1.3.1 (Alpha) > Reporter: Wendy Smoak > Assignee: Maria Catherine Tan > Fix For: 1.4.1 (Beta) > > > In the current implementation, a build agent will accept a request from anyone who knows the url, although it will only send responses to the master url in its config file. > The agent should only accept requests from its master, and should send an error response to any other requests. > On the dev list, Christian suggested using a shared secret as the simplest way for the agent to be sure the master making the request is who it says it is. See: http://www.nabble.com/How-can-an-agent-be-sure-that-a-request-comes-from-its-master--td21546892.html > Related to CONTINUUM-2041 (Master should be able to detect an incorrect master url in a build agent's config file) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira