continuum-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paolo Scapin (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (CONTINUUM-2573) Distributed builds are not distributed: they are always scheduled to the last agent defined
Date Mon, 06 Dec 2010 14:49:04 GMT

    [ http://jira.codehaus.org/browse/CONTINUUM-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=246582#action_246582
] 

Paolo Scapin commented on CONTINUUM-2573:
-----------------------------------------

Builds are not sent to the last agent they were built on: they are always sent to the last
agent that is defined. This is why i pointed out that there is point in defining more than
one agent.
We patched the code locally and now the patched version works as expected.
I am not sure how this was working for you before.
Configuration: we defined one group with 4 agents, 2 win and 2 linux machines.


> Distributed builds are not distributed: they are always scheduled to the last agent defined
> -------------------------------------------------------------------------------------------
>
>                 Key: CONTINUUM-2573
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-2573
>             Project: Continuum
>          Issue Type: Bug
>          Components: Distributed Builds
>    Affects Versions: 1.3.6
>            Reporter: Paolo Scapin
>            Priority: Critical
>             Fix For: 1.4.2 (Beta)
>
>
> When more than one agent are available for distributed build, every build is queued to
the last one defined.
> This way distributed builds are useless.
> The issue is caused by a small bug in class org.apache.continuum.builder.distributed.manager.DefaultDistributedBuildManager,
in method getOverallDistributedBuildQueueByAgentGroup, where the index "idx" ios never incremented
> line 916:
> int idx = 0;
> then idx is checked to  assign the first queue
> line 932:
> if ( idx == 0 )
> {
>    whereToBeQueued = distributedBuildQueue;
>    size = agentBuildSize;
> }
> but is never incremented.
> idx should be incremented at line 953, inside the for cycle.
> A similar cycle in the next method (getOverallDistributedBuildQueue) is implemented correctly
> Please can anybody insert a fix in the next release?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message