continuum-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paolo Scapin (JIRA)" <j...@codehaus.org>
Subject [jira] Created: (CONTINUUM-2573) Distributed builds are not distributed: they are always scheduled to the last agent defined
Date Mon, 18 Oct 2010 08:45:32 GMT
Distributed builds are not distributed: they are always scheduled to the last agent defined
-------------------------------------------------------------------------------------------

                 Key: CONTINUUM-2573
                 URL: http://jira.codehaus.org/browse/CONTINUUM-2573
             Project: Continuum
          Issue Type: Bug
          Components: Distributed Builds
    Affects Versions: 1.3.6
            Reporter: Paolo Scapin
            Priority: Critical


When more than one agent are available for distributed build, every build is queued to the
last one defined.
This way distributed builds are useless.

The issue is caused by a small bug in class org.apache.continuum.builder.distributed.manager.DefaultDistributedBuildManager,
in method getOverallDistributedBuildQueueByAgentGroup, where the index "idx" ios never incremented

line 916:

int idx = 0;

then idx is checked to  assign the first queue

line 932:
if ( idx == 0 )
{
   whereToBeQueued = distributedBuildQueue;
   size = agentBuildSize;
}

but is never incremented.

idx should be incremented at line 953, inside the for cycle.

A similar cycle in the next method (getOverallDistributedBuildQueue) is implemented correctly

Please can anybody insert a fix in the next release?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message