continuum-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Wienert (JIRA)" <j...@codehaus.org>
Subject [jira] Created: (CONTINUUM-2281) Same Recipiant will be added several times in Notification
Date Mon, 29 Jun 2009 15:34:05 GMT
Same Recipiant will be added several times in Notification
----------------------------------------------------------

                 Key: CONTINUUM-2281
                 URL: http://jira.codehaus.org/browse/CONTINUUM-2281
             Project: Continuum
          Issue Type: Bug
          Components: Core system, Notifier - Mail
    Affects Versions: 1.3.3, 1.3.4
         Environment: Windows, Tomcat, JDK 5, Subversion
            Reporter: Klaus Wienert
            Priority: Minor
         Attachments: 2009-06-29_171922.png

If notifier configuration is committers = true, then for each SCM change the Author is added
in To Address. Even if the Author is already a Recipient. The Author will only get one email,
but the To Address will get right long.

http://svn.apache.org/repos/asf/continuum/tags/continuum-1.3.3/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java


                                    for ( ChangeSet changeSet : changes )
                                    {
                                        String scmId = changeSet.getAuthor();
                                        if ( StringUtils.isNotEmpty( scmId ) )
                                        {
                                            String email = developerToEmailMap.get( scmId
);
                                            if ( StringUtils.isEmpty( email ) )
                                            {
                                                //TODO: Add a default domain so mail address
won't be required
                                                log.warn(
                                                    "no email address is defined in developers
list for '" + scmId +
                                                        "' scm id." );
                                            }
                                            else
                                            {
                                                // TODO: set a proper name
                                                InternetAddress to = new InternetAddress(
email.trim() );
                                                log.info( "Recipient: To '" + to + "'." );

                                                message.addRecipient( Message.RecipientType.TO,
to );
                                            }
                                        }
                                    }





	<ciManagement>
		<system>continuum</system>
		<url>http://server/continuum/</url>
		<notifiers>
			<notifier>
				<type>mail</type>
				<sendOnError>true</sendOnError>
				<sendOnFailure>true</sendOnFailure>
				<sendOnSuccess>false</sendOnSuccess>
				<sendOnWarning>true</sendOnWarning>
				<configuration>
                    <committers>true</committers>
                </configuration>
			</notifier>
		</notifiers>
	</ciManagement>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message