continuum-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wendy Smoak (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (CONTINUUM-565) Forced builds should say who (which continuum user) forced the build
Date Fri, 15 May 2009 18:40:44 GMT

    [ http://jira.codehaus.org/browse/CONTINUUM-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=176661#action_176661
] 

Wendy Smoak commented on CONTINUUM-565:
---------------------------------------

Initial investigation

DefaultBuildController.java has method
public void build( int projectId, int buildDefinitionId, int trigger, ScmResult scmResult
)

'build' is called from BuildProjectTaskExecutor.java:
{noformat}
    public void executeTask( Task task ) throws TaskExecutionException {
        BuildProjectTask buildProjectTask = (BuildProjectTask) task;
        controller.build( buildProjectTask.getProjectId(), buildProjectTask.getBuildDefinitionId(),
buildProjectTask.getTrigger(), buildProjectTask.getScmResult() );
    }
{noformat}

 - 'trigger' is an integer, no additional info such as username is passed in
 - Brett suggested 'trigger' should be a class rather than an int
 - username needs to get into BuildProjectTask so it's available in BuildProjectTaskExecutor
when calling controller.build

more in 20090514 #continuum irc log

> Forced builds should say who (which continuum user) forced the build
> --------------------------------------------------------------------
>
>                 Key: CONTINUUM-565
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-565
>             Project: Continuum
>          Issue Type: Improvement
>          Components: Core system
>            Reporter: Jamie Flournoy
>            Priority: Minor
>             Fix For: 1.x
>
>
> Currently if a build is forced the build history and notifications don't say who forced
it. It would be nice if that was part of the history and notifications.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message