From issues-return-2745-apmail-continuum-issues-archive=continuum.apache.org@continuum.apache.org Wed Mar 04 20:59:40 2009 Return-Path: Delivered-To: apmail-continuum-issues-archive@www.apache.org Received: (qmail 90253 invoked from network); 4 Mar 2009 20:59:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Mar 2009 20:59:40 -0000 Received: (qmail 11614 invoked by uid 500); 4 Mar 2009 20:59:40 -0000 Delivered-To: apmail-continuum-issues-archive@continuum.apache.org Received: (qmail 11581 invoked by uid 500); 4 Mar 2009 20:59:40 -0000 Mailing-List: contact issues-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list issues@continuum.apache.org Received: (qmail 11558 invoked by uid 99); 4 Mar 2009 20:59:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2009 12:59:40 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com) (63.246.2.115) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Mar 2009 20:59:33 +0000 Received: from codehaus01.managed.contegix.com (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id F3A5214A8169 for ; Wed, 4 Mar 2009 14:59:12 -0600 (CST) Message-ID: <17897497.1236200352913.JavaMail.haus-jira@codehaus01.managed.contegix.com> Date: Wed, 4 Mar 2009 14:59:12 -0600 (CST) From: "Wendy Smoak (JIRA)" To: issues@continuum.apache.org Subject: [jira] Commented: (CONTINUUM-2102) Unable to configure subject line for email notifications In-Reply-To: <29146817.1235792419670.JavaMail.haus-jira@codehaus01.managed.contegix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 4e90ceb663894a42f12c0e28abbab431 X-Virus-Checked: Checked by ClamAV on apache.org [ http://jira.codehaus.org/browse/CONTINUUM-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=167914#action_167914 ] Wendy Smoak commented on CONTINUUM-2102: ---------------------------------------- Thanks! I'd say go ahead and commit what you have, which makes the 'prepare build' subject line configurable... it sounds fine, it just needs to be documented. If the 'PREPARE BUILD SUCCESSFUL' notifications get too noisy or are considered redundant, we can consider removing them in a separate issue. > Unable to configure subject line for email notifications > -------------------------------------------------------- > > Key: CONTINUUM-2102 > URL: http://jira.codehaus.org/browse/CONTINUUM-2102 > Project: Continuum > Issue Type: Bug > Components: Notifier - Mail > Affects Versions: 1.3.2 > Environment: 1.3.1, also seen with trunk at r748719 > Reporter: Wendy Smoak > Priority: Critical > > After upgrading to 1.3.x, I'm getting notification emails with the subject line: > [continuum] PREPARE BUILD SUCCESSFUL: ${projectScmRoot.scmRootAddress} > Other than the subject, the notification looks the same as we used to get for normal scheduled builds in 1.2.x. > The subject line seems to be hard coded in MailContinuumNotifier.java, and was added in r709300 in the merge from the transient state branch. > Previously, the subject was configurable in > ./apps/continuum/WEB-INF/classes/META-INF/plexus/application.xml > with > [continuum] BUILD ${state}: ${project.projectGroup.name} - ${project.name} - ${build.buildDefinition.description} > . > From continuum.log: > 2009-02-27 20:25:48,106 [pool-1-thread-4] WARN velocityComponent - org.apache.velocity.runtime.exception.ReferenceException: reference : template = subjectPattern [line 1,column 37] : ${projectScmRoot.scmRootAddress} is not a valid reference. > 2009-02-27 20:25:48,106 [pool-1-thread-4] INFO org.apache.maven.continuum.notification.mail.MailContinuumNotifier - Message Subject: '[continuum] PREPARE BUILD SUCCESSFUL: ${projectScmRoot.scmRootAddress}'. > I'm less concerned about the 'not a valid reference' warning, since what I really want is for the subject line to be > - configurable in plain text > - the same as it was in 1.2.x > Related thread: > http://mail-archives.apache.org/mod_mbox/continuum-dev/200902.mbox/%3Cadba96190902261025o5f0f35cfk70554c62cafda630@mail.gmail.com%3E -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira