continuum-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wendy Smoak (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (CONTINUUM-2102) Unable to configure subject line for email notifications
Date Wed, 04 Mar 2009 20:59:12 GMT

    [ http://jira.codehaus.org/browse/CONTINUUM-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=167914#action_167914
] 

Wendy Smoak commented on CONTINUUM-2102:
----------------------------------------

Thanks!  I'd say go ahead and commit what you have, which makes the 'prepare build' subject
line configurable... it sounds fine, it just needs to be documented.  

If the 'PREPARE BUILD SUCCESSFUL' notifications get too noisy or are considered redundant,
we can consider removing them in a separate issue. 

> Unable to configure subject line for email notifications
> --------------------------------------------------------
>
>                 Key: CONTINUUM-2102
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-2102
>             Project: Continuum
>          Issue Type: Bug
>          Components: Notifier - Mail
>    Affects Versions: 1.3.2
>         Environment: 1.3.1, also seen with trunk at r748719
>            Reporter: Wendy Smoak
>            Priority: Critical
>
> After upgrading to 1.3.x, I'm getting notification emails with the subject line:
> [continuum] PREPARE BUILD SUCCESSFUL: ${projectScmRoot.scmRootAddress}
> Other than the subject, the notification looks the same as we used to get for normal
scheduled builds in 1.2.x.
> The subject line seems to be hard coded in MailContinuumNotifier.java, and was added
in r709300 in the merge from the transient state branch.  
> Previously, the subject was configurable in
>         ./apps/continuum/WEB-INF/classes/META-INF/plexus/application.xml
> with
>         <subject-format>[continuum] BUILD ${state}: ${project.projectGroup.name}
- ${project.name} - ${build.buildDefinition.description}</subject-format>
> .
> From continuum.log:
> 2009-02-27 20:25:48,106 [pool-1-thread-4] WARN  velocityComponent  - org.apache.velocity.runtime.exception.ReferenceException:
reference : template = subjectPattern [line 1,column 37] : ${projectScmRoot.scmRootAddress}
is not a valid reference.
> 2009-02-27 20:25:48,106 [pool-1-thread-4] INFO  org.apache.maven.continuum.notification.mail.MailContinuumNotifier
 - Message Subject: '[continuum] PREPARE BUILD SUCCESSFUL: ${projectScmRoot.scmRootAddress}'.
> I'm less concerned about the 'not a valid reference' warning, since what I really want
is for the subject line to be 
>  - configurable in plain text
>  - the same as it was in 1.2.x
> Related thread:
> http://mail-archives.apache.org/mod_mbox/continuum-dev/200902.mbox/%3Cadba96190902261025o5f0f35cfk70554c62cafda630@mail.gmail.com%3E

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message