continuum-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larvell Jones (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (CONTINUUM-1915) Continuum 1.2 does not build the project when it has changes in sub-modules
Date Tue, 28 Oct 2008 22:11:51 GMT

    [ http://jira.codehaus.org/browse/CONTINUUM-1915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=152203#action_152203
] 

Larvell Jones commented on CONTINUUM-1915:
------------------------------------------

shouldBuild in MavenTwoBuildExecutor is using the incorrect logic to determine if build is
recursive.

{code}
boolean isRecursive = StringUtils.isNotEmpty( buildDefinition.getArguments() ) &&
!(
            buildDefinition.getArguments().indexOf( "-N" ) < 0 ||
                buildDefinition.getArguments().indexOf( "--non-recursive" ) < 0 );
{code}

Should be:

{code}
boolean isRecursive = StringUtils.isNotEmpty( buildDefinition.getArguments() ) &&
(
            buildDefinition.getArguments().indexOf( "-N" ) < 0 && 
                buildDefinition.getArguments().indexOf( "--non-recursive" ) < 0 );
{code}

> Continuum 1.2 does not build the project when it has changes in sub-modules
> ---------------------------------------------------------------------------
>
>                 Key: CONTINUUM-1915
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1915
>             Project: Continuum
>          Issue Type: Bug
>          Components: Integration - Maven 2
>    Affects Versions: 1.2
>         Environment: Linux
>            Reporter: apache maillist
>            Priority: Critical
>
> Log shows:
> 2008-10-01 18:00:04,701 [pool-1-thread-1] INFO  action#update-working-directory-from-scm
 - Updated 2 files.
> 2008-10-01 18:00:04,732 [pool-1-thread-1] INFO  buildController  - Merging SCM results
> 2008-10-01 18:00:05,011 [pool-1-thread-1] INFO  continuumBuildExecutor#maven2  - Changes
are only in sub-modules.
> 2008-10-01 18:00:05,019 [pool-1-thread-1] INFO  buildController  - No changes in the
current project, not building
> In continuum, the working copy looks like this
> - parent-md
> - mycommon
> - myintegration
> - mybusiness
> - mydo
> - pom.xml
> the pom.xml is used for adding project into continuum
> the pom.xml consist of those projects
>     <modules>
>         <module>parent-md</module>
>         <module>mycommon</module>
>         <module>myintegration</module>
>         <module>mybusiness</module>
>         <module>mydo</module>
>     </modules>
> parent-md is the parentpom for all project listed
> After developer making changes in sub-modules ex: myintegration in SVN, continuum detects
the changes during schedule run but nothing gets built even myintegration itslef. This model
works well in 1.1.
> Now all of our 10+ projects with 50+ sub-modules in total stop building by schedule.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message