Mailing-List: contact issues-help@continuum.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@continuum.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: 
 <14647042.1221113091367.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Date: Thu, 11 Sep 2008 01:04:51 -0500 (CDT)
From: "Napoleon Esmundo C. Ramirez (JIRA)" <jira@codehaus.org>
To: issues@continuum.apache.org
Subject: [jira] Commented: (CONTINUUM-1874) continuum:add-maven-two-project
 doesn't work
In-Reply-To: 
 <30941599.1220969388826.JavaMail.haus-jira@codehaus01.managed.contegix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit


    [ http://jira.codehaus.org/browse/CONTINUUM-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=147625#action_147625 ] 

Napoleon Esmundo C. Ramirez commented on CONTINUUM-1874:
--------------------------------------------------------

How about using a default value if the project url doesn't end in .xml?  For example, if the url is something like http://myhost.com/repos/myproject/trunk, the plugin should append the missing default pom.xml.  But if it is something like http://myhost.com/repos/myproject/trunk/custom-pom.xml, then the plugin shouldn't override it.

I tried:
{noformat}
$ mvn org.apache.continuum:continuum-maven-plugin:1.2-SNAPSHOT:add-maven-two-project -o -Durl=http://localhost:9090/xmlrpc -Dusername=admin -Dpassword=****** -N
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Building multimodule-parent
[INFO]    task-segment: [org.apache.continuum:continuum-maven-plugin:1.2-SNAPSHOT:add-maven-two-project]
[INFO] ------------------------------------------------------------------------
[INFO] [continuum:add-maven-two-project]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESSFUL
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 8 seconds
[INFO] Finished at: Thu Sep 11 13:55:16 PHT 2008
[INFO] Final Memory: 10M/82M
[INFO] ------------------------------------------------------------------------
$
{noformat}

..and continuum added just the parent.


> continuum:add-maven-two-project doesn't work
> --------------------------------------------
>
>                 Key: CONTINUUM-1874
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1874
>             Project: Continuum
>          Issue Type: Bug
>          Components: Maven Plugin
>    Affects Versions: 1.2
>         Environment: JDK1.5, Maven 2.0.9, Continuum 1.2
>            Reporter: Napoleon Esmundo C. Ramirez
>            Priority: Blocker
>             Fix For: 1.2.1
>
>
> When doing a:
> {noformat}
> $ mvn org.apache.continuum:continuum-maven-plugin:1.2:add-maven-two-project -Durl=http://localhost:9090/xmlrpc -Dusername=admin -Dpassword=******
> {noformat}
> I get something like this:
> {noformat}
> [INFO] Scanning for projects...
> [INFO] ------------------------------------------------------------------------
> [INFO] Building quickstart
> [INFO]    task-segment: [org.apache.continuum:continuum-maven-plugin:1.2:add-maven-two-project]
> [INFO] ------------------------------------------------------------------------
> [INFO] [continuum:add-maven-two-project]
> [ERROR] fail to add mavenTwo project add.project.project.building.error
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] fail to add mavenTwo project add.project.project.building.error
> [INFO] ------------------------------------------------------------------------
> [INFO] For more information, run Maven with the -e switch
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 5 seconds
> [INFO] Finished at: Tue Sep 09 20:55:57 PHT 2008
> [INFO] Final Memory: 10M/83M
> [INFO] ------------------------------------------------------------------------
> $
> {noformat}
> In AddMavenTwoProject.java, it defines the pom url as only the containing directory of the pom.xml:
> {code:java}
> /**
>   * POM Url.
>   *
>   * @parameter expression="${projectUrl}" default-value="${project.scm.url}"
>   * @required
>   */
> private String projectUrl;
> {code}
> I tried appending a {{/pom.xml}} in the {{default-value}}, and I was able to add the project then.
> {code:java}
> /**
>   * POM Url.
>   *
>   * @parameter expression="${projectUrl}" default-value="${project.scm.url}/pom.xml"
>   * @required
>   */
> private String projectUrl;
> {code}
> {noformat}
> $ mvn org.apache.continuum:continuum-maven-plugin:1.2:add-maven-two-project -Durl=http://localhost:9090/xmlrpc -Dusername=admin -Dpassword=******
> [INFO] Scanning for projects...
> [INFO] ------------------------------------------------------------------------
> [INFO] Building quickstart
> [INFO]    task-segment: [org.apache.continuum:continuum-maven-plugin:1.2:add-maven-two-project]
> [INFO] ------------------------------------------------------------------------
> [INFO] [continuum:add-maven-two-project]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESSFUL
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 8 seconds
> [INFO] Finished at: Tue Sep 09 21:31:43 PHT 2008
> [INFO] Final Memory: 10M/82M
> [INFO] ------------------------------------------------------------------------
> $
> {noformat}
> At first, I thought it fixed the problem.  But when I tried adding a multi-module project, e.g.:
> {noformat}
> multimodule-parent/pom.xml
>   | 
>   +--submodule-one/pom.xml
>   | 
>   +--submodule-two/pom.xml
>   | 
>   +--submodule-three/pom.xml
> {noformat}
> Continuum added the project defined by {{multimodule-parent/pom.xml}} four times.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira