continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brent Atkinson <brent.atkin...@gmail.com>
Subject Re: svn commit: r1542934 - /continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java
Date Sat, 30 Nov 2013 17:54:48 GMT
Hi Brett,

I am new to review via the commit list. If I am doing things that I can
improve upon, don't be shy to critique. I will consider the correction a
high compliment.


@@ -160,9 +159,7 @@ public abstract class AbstractPurgeTest
>      protected void goToAddDirectoryPurge()
>      {
>          goToGeneralPurgePage();
> -        assertGeneralPurgePage();
>

Is there a reason that the assert was removed here and not in the other
method?


> -        clickLinkWithXPath(
> -            "//preceding::input[@value='directory' and
> @type='hidden']//following::input[@type='submit']" );
> +        clickLinkWithXPath(
> "//form[@name='addDirPurgeConfig']/input[@type='submit']" );
>          assertAddEditDirectoryPurgePage();
>      }
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message