From dev-return-8897-apmail-continuum-dev-archive=continuum.apache.org@continuum.apache.org Wed Dec 08 12:56:43 2010 Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 29051 invoked from network); 8 Dec 2010 12:56:43 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 8 Dec 2010 12:56:43 -0000 Received: (qmail 43762 invoked by uid 500); 8 Dec 2010 12:56:43 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 43619 invoked by uid 500); 8 Dec 2010 12:56:43 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 43611 invoked by uid 99); 8 Dec 2010 12:56:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Dec 2010 12:56:42 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [72.26.105.223] (HELO cell.g2ix.net) (72.26.105.223) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Dec 2010 12:56:36 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by cell.g2ix.net (Postfix) with ESMTP id 1699610B8043 for ; Wed, 8 Dec 2010 04:56:16 -0800 (PST) X-Virus-Scanned: amavisd-new at cell.g2ix.net Received: from cell.g2ix.net ([127.0.0.1]) by localhost (cell.g2ix.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LbBJGqkc4nMm for ; Wed, 8 Dec 2010 04:56:11 -0800 (PST) Received: from cell.g2ix.net (cell [172.18.10.223]) by cell.g2ix.net (Postfix) with ESMTP id DC00110B8042 for ; Wed, 8 Dec 2010 04:56:11 -0800 (PST) Date: Wed, 8 Dec 2010 04:56:11 -0800 (PST) From: Mark John Kennedy Magallanes To: dev@continuum.apache.org Message-ID: <1036216507.1207.1291812971810.JavaMail.root@cell.g2ix.net> In-Reply-To: <313150848.1199.1291812556128.JavaMail.root@cell.g2ix.net> Subject: Re: proposal to add platform field in the model used for build agents for continuum master MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [58.71.19.178] X-Mailer: Zimbra 6.0.5_GA_2213.RHEL5_64 (ZimbraWebClient - FF3.0 (Linux)/6.0.5_GA_2213.RHEL5_64) hi brett, Thanks for the suggestion sir brett, With that you mean the build agent would have a web service method to know its OS name so that when a build agent is added it would try to connect to it's web service to know it's operating system. In addition I think it we could already get it's enabled state too so the user will no longer have tell weather its enabled or not. if you have more suggestions please don't hesitate. Thanks Mark Magallanes ----- Original Message ----- From: "Brett Porter" To: dev@continuum.apache.org Sent: Wednesday, December 8, 2010 8:07:49 PM Subject: Re: proposal to add platform field in the model used for build agents for continuum master I think it's a good direction for the build agent to be specifying more of its own information rather than the master trying to tell it who it is. However, I'd go with deriving the data rather than asking the user to specify it - otherwise you could get small inconsistencies creep in. In the utils libraries there is an Os class that can send back the full OS name, or just the family. These might help the master make decisions on how to group them without putting any burden on the agent to decide / configure anything. - Brett On 07/12/2010, at 4:45 PM, Mark John Kennedy Magallanes wrote: > hi all, > > I'm proposing to add a String field to the BuildAgentConfiguration model used in by the continuum > master to save build agents. Right now BuildAgentConfiguration has the following fields String url, > String description, boolean enabled, I'm suggesting to add another field String platform so that > the continuum master could keep track of the platform of the registered build agents in the continuum > master. This will in a way lessen the task when you want to know the available platforms of the build > agents registered in the continuum master since it will also be recorded in the continuum.xml rather > than reading each registered build agents to know it's platform. > > any feedback to my proposal? or any other suggestions? > > > Thanks, > > Mark Magallanes > > -- Brett Porter brett@apache.org http://brettporter.wordpress.com/ http://au.linkedin.com/in/brettporter