Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 62318 invoked from network); 15 Jun 2010 06:50:42 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Jun 2010 06:50:42 -0000 Received: (qmail 25853 invoked by uid 500); 15 Jun 2010 06:50:42 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 25702 invoked by uid 500); 15 Jun 2010 06:50:38 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 25694 invoked by uid 99); 15 Jun 2010 06:50:36 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jun 2010 06:50:36 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.212.171] (HELO mail-px0-f171.google.com) (209.85.212.171) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jun 2010 06:50:29 +0000 Received: by pxi19 with SMTP id 19so10731413pxi.2 for ; Mon, 14 Jun 2010 23:50:07 -0700 (PDT) Received: by 10.114.4.37 with SMTP id 37mr5397858wad.120.1276584606719; Mon, 14 Jun 2010 23:50:06 -0700 (PDT) Received: from [10.0.0.10] (CPE-124-184-4-53.lns10.cht.bigpond.net.au [124.184.4.53]) by mx.google.com with ESMTPS id b6sm64610986wam.9.2010.06.14.23.50.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 14 Jun 2010 23:50:05 -0700 (PDT) Sender: Brett Porter Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1078) Subject: Re: svn commit: r954720 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java From: Brett Porter In-Reply-To: <20100615061851.A106C23888E4@eris.apache.org> Date: Tue, 15 Jun 2010 16:49:59 +1000 Content-Transfer-Encoding: quoted-printable Message-Id: <32D6044C-381B-4E59-9877-BA8192806A54@apache.org> References: <20100615061851.A106C23888E4@eris.apache.org> To: dev@continuum.apache.org X-Mailer: Apple Mail (2.1078) X-Virus-Checked: Checked by ClamAV on apache.org That's: http://jira.codehaus.org/browse/CONTINUUM-2520 I think it'd be good for others to go through the issues in the = Unscheduled bucket from time to time, to make sure the issues are valid = (and check for patches!) I try to do it once a week... - Brett On 15/06/2010, at 4:18 PM, ctan@apache.org wrote: > Author: ctan > Date: Tue Jun 15 06:18:51 2010 > New Revision: 954720 >=20 > URL: http://svn.apache.org/viewvc?rev=3D954720&view=3Drev > Log: > prevent NPE when build result or project is null >=20 > Modified: > = continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/no= tification/mail/MailContinuumNotifier.java >=20 > Modified: = continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/no= tification/mail/MailContinuumNotifier.java > URL: = http://svn.apache.org/viewvc/continuum/trunk/continuum-core/src/main/java/= org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java?re= v=3D954720&r1=3D954719&r2=3D954720&view=3Ddiff > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- = continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/no= tification/mail/MailContinuumNotifier.java (original) > +++ = continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/no= tification/mail/MailContinuumNotifier.java Tue Jun 15 06:18:51 2010 > @@ -251,8 +251,17 @@ public class MailContinuumNotifier > Project project =3D context.getProject(); > List notifiers =3D context.getNotifiers(); > BuildResult build =3D context.getBuildResult(); > - log.error( "br state=3D"+build.getState() ); > - log.error( "project state=3D"+project.getState() ); > + > + if ( build !=3D null ) > + { > + log.error( "br state=3D"+build.getState() ); > + } > + > + if ( project !=3D null ) > + { > + log.error( "project state=3D"+project.getState() ); > + } > + > BuildDefinition buildDefinition =3D = context.getBuildDefinition(); > ProjectScmRoot projectScmRoot =3D context.getProjectScmRoot(); >=20 >=20 >=20 -- Brett Porter brett@apache.org http://brettporter.wordpress.com/