From dev-return-8608-apmail-continuum-dev-archive=continuum.apache.org@continuum.apache.org Wed Feb 03 06:31:27 2010 Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 70197 invoked from network); 3 Feb 2010 06:31:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Feb 2010 06:31:27 -0000 Received: (qmail 37319 invoked by uid 500); 3 Feb 2010 06:31:27 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 37157 invoked by uid 500); 3 Feb 2010 06:31:26 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 37147 invoked by uid 99); 3 Feb 2010 06:31:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2010 06:31:26 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of marica.tan@gmail.com designates 209.85.222.186 as permitted sender) Received: from [209.85.222.186] (HELO mail-pz0-f186.google.com) (209.85.222.186) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2010 06:31:17 +0000 Received: by pzk16 with SMTP id 16so997246pzk.14 for ; Tue, 02 Feb 2010 22:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=v//XeDkCg33T+P+ptkDB50iV24il1U+l9fLLbunkqV0=; b=pj/gWlhtQvIrWeO3BCHpzcEsmnsNFQrOzTGcZqkdOPdzEMFylY/T/Uy6MPztJHTUy/ H60HfeOHv5LbVQCr/Xk8GJz6hS58+5eVjUuRxQ4tLvVlJ9j1sHHr0yM+GxP2dfxHaX3m QIstd9L2jZwYLA1eMXq0M+JNmIfTzBGAHXxLM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=m/QQsrJWJxxyAdiHnkqHhVP615XLZ23+PaNATI/0UKA0DkdQMW442M5jIpDaM2JDxl NRu0qFfssHFBavTzSfZSLCBFJmDHIq253OgHRRHRGgvrDP0fJagPYlBP4Z1oo+oZXs+r 2NBq4JTbqkNEn7ykeoaV6mw0NcXpRQCB91zs0= MIME-Version: 1.0 Received: by 10.143.21.16 with SMTP id y16mr1237836wfi.215.1265178654058; Tue, 02 Feb 2010 22:30:54 -0800 (PST) In-Reply-To: <4B68E64A.2010208@gmail.com> References: <4B665142.5080909@gmail.com> <83EADAFF-C956-4214-8872-AEFFDE7F994C@apache.org> <4B681D67.90301@gmail.com> <4B68E64A.2010208@gmail.com> Date: Wed, 3 Feb 2010 14:30:54 +0800 Message-ID: Subject: Re: Thoughts on build environment selection when releasing in distributed build setup From: Marica Tan To: dev@continuum.apache.org Content-Type: multipart/alternative; boundary=00504502cc5440aac8047eac5c8d X-Virus-Checked: Checked by ClamAV on apache.org --00504502cc5440aac8047eac5c8d Content-Type: text/plain; charset=ISO-8859-1 On Wed, Feb 3, 2010 at 10:58 AM, Jevica Arianne B. Zurbano < jevica.arianne@gmail.com> wrote: > From what I have investigated, the current behavior is that it only updates > the working copy (UpdateWorkingCopyPhase.java code snippet below) that is > why the working copy is needed and attempting to release it on another build > agent might fail if the working copy is not found. IMO, the checking out of > the working copy could be applied in this case. > > try > { > result = provider.update( repository, new ScmFileSet( new File( > releaseDescriptor.getWorkingDirectory() ) ), (ScmVersion) null ); > } > catch ( ScmException e ) > > This is already out of the scope for this issue :) We can create another issue that will handle this. > The build agent to be used is determined or taken from the last project > build result (DefaultDistributedReleaseManager.java code snippet below). > This is why it always result to using the last or default build agent. > However, it is possible to set it to use the build agent from the selected > environment. > > BuildResult buildResult = buildResultDao.getLatestBuildResultForProject( > project.getId() ); > String buildAgentUrl = buildResult.getBuildUrl(); > > > IMHO, we could have a simple fix for now, like being able to set an environment variable (e.g. heap size) or a build tool (jdk, maven or ant) during release and then ignore the build agent group in the build environment for the meantime. Thanks, -- Marica > > > Marica Tan wrote: > >> I think the reasons why it needs to have a previous successful build are: >> >> 1. to make sure there is a working copy >> 2. to make sure we have a successful build before we tag. there is no >> sense >> to release a project if the build failed because the release will fail as >> well. >> >> >> Thanks, >> - >> Marica >> >> On Wed, Feb 3, 2010 at 9:14 AM, Wendy Smoak wrote: >> >> >> >>> I had a long conversation with myself about this on the drive home, >>> and I keep going in circles. I don't know how much of the existing >>> behavior is intentional vs. incidental. >>> >>> In non-distributed build, it will not let you do a release unless the >>> projects are in 'build success' state. Obviously, the release happens >>> on that working copy. >>> >>> Carrying that over to distributed build, you still have to have a >>> previous successful build. IF the release has to happen on that >>> working copy, then you don't get to pick the build agent. And since >>> the build agent is part of the build environment... >>> >>> So, can someone explain why you have to have a previous successful >>> build in order to do a release? It's not a requirement at the maven >>> command line. The release might fail, but you are not prevented from >>> trying it. >>> >>> Is this a real requirement, or can we go with Brett's idea that >>> Continuum Release should do a checkout, which would mean it could >>> happen anywhere? >>> >>> >> > +1 on doing a checkout > I am not sure if this is a requirement though. > > > Honestly I think this work should be delayed until the architecture >>> changes are sorted out. It shouldn't be this complicated. >>> -- >>> Wendy >>> >>> >>> >> >> >> > > -- > > Thanks, > > Jev > > --00504502cc5440aac8047eac5c8d--