Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@continuum.apache.org
Received-SPF: pass (nike.apache.org: domain of marica.tan@gmail.com designates
 209.85.222.181 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=hsPwXCf3aheQaRgIXBxRTFd15n/7RxxVsbsVs7h48FNVg20K+7jxwXGjI+RAbwIng0
         BtP7tKPt5puCkvHUvH3Ix0ZQ1Dvc/GcvqY+yy/Rk/cbDxZ1CcbP6I5hbALaS6jZ77PHy
         q61oKmvTSy0WIOkBt9X5l/u8AuNvSdOg6sroQ=
MIME-Version: 1.0
In-Reply-To: <474D90BE-D0E5-42A9-A061-B8B8E530B3ED@apache.org>
References: <20100108034302.2D2D22388994@eris.apache.org>
	 <474D90BE-D0E5-42A9-A061-B8B8E530B3ED@apache.org>
Date: Fri, 8 Jan 2010 14:19:13 +0800
Message-ID: <baaa738d1001072219t6483f05dk4922c08c8769a49b@mail.gmail.com>
Subject: Re: svn commit: r897084 - in
 /continuum/branches/continuum-1.3.x/continuum-webapp/src:
	main/java/org/apache/maven/continuum/web/action/
 test/java/org/apache/maven/continuum/web/action/
	test/java/org/apache/maven/continuum/web/action/stub/
From: Marica Tan <marica.tan@gmail.com>
To: dev@continuum.apache.org
Content-Type: multipart/alternative; boundary=001636ed68e6a33e0f047ca12a87

--001636ed68e6a33e0f047ca12a87
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Jan 8, 2010 at 1:28 PM, Brett Porter <brett@apache.org> wrote:

>
> On 08/01/2010, at 2:42 PM, ctan@apache.org wrote:
>
> > -        buildResult = getContinuum().getBuildResult( getBuildId() );
> > +        try
> > +        {
> > +            buildResult = getContinuum().getBuildResult( getBuildId() );
> > +        }
> > +        catch ( ContinuumException e )
> > +        {
> > +            buildResult = null;
> > +        }
>
> Is there a need to log the exception or does it provide no value?
>
> No. The reason why I tried to catch the exception is so that I'll know if
the user is actually trying to view the current build result.

I think i'll change this.

> > +
> > +                ConfigurationService configuration =
> getContinuum().getConfiguration();
> > +
> > +                if ( configuration.isDistributedBuildEnabled() &&
> > +                                project.getState() ==
> ContinuumProjectState.BUILDING )
> > +                {
> > +                    model.setLatestBuildId( 0 );
> > +                }
>
> Why is this only 0'd on the distributed build scenario?
>
>
In a distributed build scenario, the latestBuild will point to a previous
build result because the current build result will be created after the
project finishes its build.


> - Brett
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
>
>
>
>
>

--001636ed68e6a33e0f047ca12a87--