Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 85131 invoked from network); 8 Jan 2010 05:28:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Jan 2010 05:28:49 -0000 Received: (qmail 82653 invoked by uid 500); 8 Jan 2010 05:28:49 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 82519 invoked by uid 500); 8 Jan 2010 05:28:49 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 82509 invoked by uid 99); 8 Jan 2010 05:28:48 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2010 05:28:48 +0000 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.160.51] (HELO mail-pw0-f51.google.com) (209.85.160.51) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Jan 2010 05:28:37 +0000 Received: by pwj15 with SMTP id 15so12834949pwj.10 for ; Thu, 07 Jan 2010 21:28:17 -0800 (PST) Received: by 10.142.60.3 with SMTP id i3mr675194wfa.19.1262928497034; Thu, 07 Jan 2010 21:28:17 -0800 (PST) Received: from ?10.0.0.10? (CPE-58-166-68-133.lnse5.cht.bigpond.net.au [58.166.68.133]) by mx.google.com with ESMTPS id 20sm18432381pzk.1.2010.01.07.21.28.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 07 Jan 2010 21:28:16 -0800 (PST) Sender: Brett Porter Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1077) Subject: Re: svn commit: r897084 - in /continuum/branches/continuum-1.3.x/continuum-webapp/src: main/java/org/apache/maven/continuum/web/action/ test/java/org/apache/maven/continuum/web/action/ test/java/org/apache/maven/continuum/web/action/stub/ From: Brett Porter In-Reply-To: <20100108034302.2D2D22388994@eris.apache.org> Date: Fri, 8 Jan 2010 16:28:11 +1100 Content-Transfer-Encoding: quoted-printable Message-Id: <474D90BE-D0E5-42A9-A061-B8B8E530B3ED@apache.org> References: <20100108034302.2D2D22388994@eris.apache.org> To: dev@continuum.apache.org X-Mailer: Apple Mail (2.1077) On 08/01/2010, at 2:42 PM, ctan@apache.org wrote: > - buildResult =3D getContinuum().getBuildResult( getBuildId() = ); > + try > + { > + buildResult =3D getContinuum().getBuildResult( = getBuildId() ); > + } > + catch ( ContinuumException e ) > + { > + buildResult =3D null; > + } Is there a need to log the exception or does it provide no value? > + > + ConfigurationService configuration =3D = getContinuum().getConfiguration(); > + > + if ( configuration.isDistributedBuildEnabled() &&=20 > + project.getState() =3D=3D = ContinuumProjectState.BUILDING ) > + { > + model.setLatestBuildId( 0 ); > + } Why is this only 0'd on the distributed build scenario? - Brett -- Brett Porter brett@apache.org http://brettporter.wordpress.com/