continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marica Tan <marica....@gmail.com>
Subject Re: svn commit: r897084 - in /continuum/branches/continuum-1.3.x/continuum-webapp/src: main/java/org/apache/maven/continuum/web/action/ test/java/org/apache/maven/continuum/web/action/ test/java/org/apache/maven/continuum/web/action/stub/
Date Fri, 08 Jan 2010 06:19:13 GMT
On Fri, Jan 8, 2010 at 1:28 PM, Brett Porter <brett@apache.org> wrote:

>
> On 08/01/2010, at 2:42 PM, ctan@apache.org wrote:
>
> > -        buildResult = getContinuum().getBuildResult( getBuildId() );
> > +        try
> > +        {
> > +            buildResult = getContinuum().getBuildResult( getBuildId() );
> > +        }
> > +        catch ( ContinuumException e )
> > +        {
> > +            buildResult = null;
> > +        }
>
> Is there a need to log the exception or does it provide no value?
>
> No. The reason why I tried to catch the exception is so that I'll know if
the user is actually trying to view the current build result.

I think i'll change this.

> > +
> > +                ConfigurationService configuration =
> getContinuum().getConfiguration();
> > +
> > +                if ( configuration.isDistributedBuildEnabled() &&
> > +                                project.getState() ==
> ContinuumProjectState.BUILDING )
> > +                {
> > +                    model.setLatestBuildId( 0 );
> > +                }
>
> Why is this only 0'd on the distributed build scenario?
>
>
In a distributed build scenario, the latestBuild will point to a previous
build result because the current build result will be created after the
project finishes its build.




> - Brett
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
>
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message