continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r897084 - in /continuum/branches/continuum-1.3.x/continuum-webapp/src: main/java/org/apache/maven/continuum/web/action/ test/java/org/apache/maven/continuum/web/action/ test/java/org/apache/maven/continuum/web/action/stub/
Date Fri, 08 Jan 2010 05:28:11 GMT

On 08/01/2010, at 2:42 PM, ctan@apache.org wrote:

> -        buildResult = getContinuum().getBuildResult( getBuildId() );
> +        try
> +        {
> +            buildResult = getContinuum().getBuildResult( getBuildId() );
> +        }
> +        catch ( ContinuumException e )
> +        {
> +            buildResult = null;
> +        }

Is there a need to log the exception or does it provide no value?

> +
> +                ConfigurationService configuration = getContinuum().getConfiguration();
> +
> +                if ( configuration.isDistributedBuildEnabled() && 
> +                                project.getState() == ContinuumProjectState.BUILDING
)
> +                {
> +                    model.setLatestBuildId( 0 );
> +                }

Why is this only 0'd on the distributed build scenario?

- Brett

--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/





Mime
View raw message