Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 56112 invoked from network); 1 Oct 2009 00:50:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Oct 2009 00:50:19 -0000 Received: (qmail 88063 invoked by uid 500); 1 Oct 2009 00:50:19 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 87975 invoked by uid 500); 1 Oct 2009 00:50:19 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 87965 invoked by uid 99); 1 Oct 2009 00:50:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2009 00:50:19 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of marica.tan@gmail.com designates 209.85.222.199 as permitted sender) Received: from [209.85.222.199] (HELO mail-pz0-f199.google.com) (209.85.222.199) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2009 00:50:09 +0000 Received: by pzk37 with SMTP id 37so4685253pzk.10 for ; Wed, 30 Sep 2009 17:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=iqo9izdMLz0DmzIJuPGzmK5Zy5yf0m1xB1maCfXqgZI=; b=KKRXGvB/4+mujdo79YjxnvIcPnwNbrlz4LWqI5uHMWwygeRD+5/LBIkAiS4O94vNcO Z3sUEQt/BVwXdH1bqyD7iffw6ioe8EdURwB6VmrOhKnsh4z79cwFbzlVlcFfcgeRI23A NHtJwI3yg/WriWk3w80192HEN3IT7wKkqQ6z4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=CvZKjnTEqi/uA0SKrgcwGVQ5ZDk7RQJFDDGeaeAOXwL3NWmVw4T0w9PUT/kDTqIWWF IoDmGnYYz0qWNix/hETUc9I9BelmWttq5FEAACm7eJMKWVJXbmQxRaWQfXfDO8AKjVTX 7yn1KKfKglFpUysfpTE3QUmXlO1ayKX6IK0+w= MIME-Version: 1.0 Received: by 10.142.247.5 with SMTP id u5mr45771wfh.44.1254358128392; Wed, 30 Sep 2009 17:48:48 -0700 (PDT) In-Reply-To: <2DD0D615-0054-41C5-985C-AE115837A671@apache.org> References: <20090930013928.6298223888BB@eris.apache.org> <2DD0D615-0054-41C5-985C-AE115837A671@apache.org> Date: Thu, 1 Oct 2009 08:48:48 +0800 Message-ID: Subject: Re: svn commit: r820144 - /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/continuum/web/action/admin/BuildAgentAction.java From: Marica Tan To: dev@continuum.apache.org Content-Type: multipart/alternative; boundary=00504502cc25a9f91b0474d502ce X-Virus-Checked: Checked by ClamAV on apache.org --00504502cc25a9f91b0474d502ce Content-Type: text/plain; charset=ISO-8859-1 I'll create one :) Thanks -- Marica On Thu, Oct 1, 2009 at 8:25 AM, Brett Porter wrote: > Right, but does it test the specific problem you fixed here? > > > On 01/10/2009, at 9:43 AM, Marica Tan wrote: > > There's already a unit test in >> org.apache.maven.continuum.configuration.ConfigurationServiceTest.java >> for >> adding/removing build agents in continuum.xml. >> >> >> On Wed, Sep 30, 2009 at 1:58 PM, Brett Porter wrote: >> >> >>> On 30/09/2009, at 11:39 AM, ctan@apache.org wrote: >>> >>> Author: ctan >>> >>>> Date: Wed Sep 30 01:39:27 2009 >>>> New Revision: 820144 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=820144&view=rev >>>> Log: >>>> [CONTINUUM-2377] store configuration changes of build agent in >>>> continuum.xml >>>> >>>> >>> Is there a way to unit test this? >>> >>> - Brett >>> >>> >>> > --00504502cc25a9f91b0474d502ce--