Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 34687 invoked from network); 7 Jun 2009 23:13:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 7 Jun 2009 23:13:41 -0000 Received: (qmail 77654 invoked by uid 500); 7 Jun 2009 23:13:53 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 77565 invoked by uid 500); 7 Jun 2009 23:13:52 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 77555 invoked by uid 99); 7 Jun 2009 23:13:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jun 2009 23:13:52 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of marica.tan@gmail.com designates 209.85.222.196 as permitted sender) Received: from [209.85.222.196] (HELO mail-pz0-f196.google.com) (209.85.222.196) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Jun 2009 23:13:44 +0000 Received: by pzk34 with SMTP id 34so2461481pzk.10 for ; Sun, 07 Jun 2009 16:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=el4F3GkWujlP4/71xUP23ZrtYbiBKsihfAk8+WCZnJ4=; b=EaFTt0kvAzqBQPry2hIzq3pzGYQQKIVT8BiNdadn7g05eHQYfSVVSKWr3t34892dHF eah2R2dzE3k/4kHaBXe2skQuTPj64uvWnNkgYaYEla92xkq2Gg1OUnrLk1x6K5z96p9H Ub/WDHRMdL8afgRWW9aGtUB+3SR+VmPTN12lQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=dm/rnOgMaMS9GdKImW5aXLFFBbtald1j+/x8Wa4FBAU8726/GG6Rr5oZMvKZhqFiQQ NWTNJ36zI6gBGH0tyd4tJZdwvQwNWrSwaAwHUIjo6e9KAOos6czxr1LLeFAKSSycHeFC CTQ1b9cUckmOjy2+SlZf11AvH3zRjLhv4dXS4= MIME-Version: 1.0 Received: by 10.115.89.18 with SMTP id r18mr10067804wal.34.1244416403427; Sun, 07 Jun 2009 16:13:23 -0700 (PDT) In-Reply-To: <730D4885-0590-4688-83B5-63838AEF0C94@apache.org> References: <20090605070424.C262C2388898@eris.apache.org> <730D4885-0590-4688-83B5-63838AEF0C94@apache.org> Date: Mon, 8 Jun 2009 07:13:23 +0800 Message-ID: Subject: Re: svn commit: r781929 - /continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java From: Marica Tan To: dev@continuum.apache.org Content-Type: multipart/alternative; boundary=00163646c580add2f7046bca45e5 X-Virus-Checked: Checked by ClamAV on apache.org --00163646c580add2f7046bca45e5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On Fri, Jun 5, 2009 at 3:14 PM, Brett Porter wrote: > what issue is this related to? > [CONTINUUM-2077] project scm root of projects are not deleted even when you already delete the projects. Since the call for removeProjectScmRoot() is inside the removeProject, if the project is already deleted, the remaining scm root will not get deleted from the database when you delete the project group. I just added a check to remove remaining scm root of the group just to prevent this from happening. Should I create an issue for this? > > On 05/06/2009, at 5:04 PM, ctan@apache.org wrote: > > Author: ctan >> Date: Fri Jun 5 07:04:24 2009 >> New Revision: 781929 >> >> URL: http://svn.apache.org/viewvc?rev=781929&view=rev >> Log: >> remove remaining project scm root when deleting the project group >> >> Modified: >> >> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java >> >> Modified: >> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java >> URL: >> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java?rev=781929&r1=781928&r2=781929&view=diff >> >> ============================================================================== >> --- >> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java >> (original) >> +++ >> continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java >> Fri Jun 5 07:04:24 2009 >> @@ -425,6 +425,14 @@ >> removeProject( projectId ); >> } >> >> + // check if there are any project scm root left >> + List scmRoots = >> getProjectScmRootByProjectGroup( projectGroupId ); >> + >> + for ( ProjectScmRoot scmRoot : scmRoots ) >> + { >> + removeProjectScmRoot( scmRoot ); >> + } >> + >> log.info( "Remove project group " + projectGroup.getName() + >> "(" + projectGroup.getId() + ")" ); >> >> Map context = new HashMap(); >> >> >> > --00163646c580add2f7046bca45e5--