Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@continuum.apache.org
Received-SPF: pass (nike.apache.org: domain of jevica.arianne@gmail.com
 designates 74.125.46.158 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=kDiMuYIpaYQxrDJFm95qISL/ewkRL4kN7OXRZj+7VwCIH4ixqCuTivBANyNSwQEhNm
         Kah6d2ebo7B8UAqaWiBPYC7HssHg5J50P27gOUy4cvPn3AyL8eFeX4ahiyo+I1A2vCZN
         EQIw9543D1ssmW0IHVDJ4qflmVUu+uP2UH/zk=
Message-ID: <4A264E6B.8060607@gmail.com>
Date: Wed, 03 Jun 2009 18:20:27 +0800
From: "Jevica Arianne B. Zurbano" <jevica.arianne@gmail.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090318)
MIME-Version: 1.0
To: dev@continuum.apache.org
Subject: Re: svn commit: r781301 -
 /continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/admin/ProfileAction.java
References: <20090603084702.82631238888E@eris.apache.org>
 <1B0CBED0-FFD7-4696-86E0-6EE33D9B1DDC@apache.org>
In-Reply-To: <1B0CBED0-FFD7-4696-86E0-6EE33D9B1DDC@apache.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

The current behavior, having "ERROR" being returned will redirect to the 
Error page with no error message and no stack trace.

And, the action error is displayed in another page; the page that is 
being accessed after the Error Occured page is displayed.

The fix is to have the action error displayed in the build environment 
list page (success page).


Brett Porter wrote:
> I don't understand how this is the correct fix. Won't an exception now 
> go to the success page and not produce an error?
>
> On 03/06/2009, at 6:47 PM, jzurbano@apache.org wrote:
>
>> Author: jzurbano
>> Date: Wed Jun  3 08:47:02 2009
>> New Revision: 781301
>>
>> URL: http://svn.apache.org/viewvc?rev=781301&view=rev
>> Log:
>> [CONTINUUM-2250] Build Environment error message is displayed on the 
>> first accessed page
>>
>> Modified:
>>    
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/admin/ProfileAction.java 
>>
>>
>> Modified: 
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/admin/ProfileAction.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/admin/ProfileAction.java?rev=781301&r1=781300&r2=781301&view=diff 
>>
>> ============================================================================== 
>>
>> --- 
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/admin/ProfileAction.java 
>> (original)
>> +++ 
>> continuum/branches/continuum-1.3.x/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/admin/ProfileAction.java 
>> Wed Jun  3 08:47:02 2009
>> @@ -183,7 +183,6 @@
>>         catch ( ProfileException e )
>>         {
>>             addActionError( getText( "profile.remove.error" ) );
>> -            return ERROR;
>>         }
>>         return SUCCESS;
>>     }
>>
>>
>
>

-- 

Thanks,

Jev