continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marica Tan <marica....@gmail.com>
Subject Re: svn commit: r775961 - in /continuum/trunk: continuum-api/src/main/java/org/apache/continuum/dao/ continuum-api/src/main/java/org/apache/maven/continuum/ continuum-core/src/main/java/org/apache/maven/continuum/ continuum-model/src/main/java/ conti
Date Mon, 18 May 2009 14:37:20 GMT
On Mon, May 18, 2009 at 10:15 PM, Brett Porter <brett@apache.org> wrote:

> HI Marica,
>
> On 19/05/2009, at 12:07 AM, ctan@apache.org wrote:
>
>  Author: ctan
>> Date: Mon May 18 14:07:51 2009
>> New Revision: 775961
>>
>> URL: http://svn.apache.org/viewvc?rev=775961&view=rev
>> Log:
>> [CONTINUUM-1712] added jpox project summary to improve performance of
>> group summary page
>> merge -r 775955:775956 of 1.3.x branch
>>
>
> sounds like a good idea. I'm wondering, do we know of the cause that it
> slowed down? If the project requests have a misconfigured fetch group it
> might affect the overall performance of the system, not just the front page.
>
> I think it just something to do with having a large number of project
groups and projects.

But we may need to investigate this some more just to be sure.

>
>
>  Modified: continuum/trunk/continuum-webapp/src/main/mdo/view-models.mdo
>> URL:
>> http://svn.apache.org/viewvc/continuum/trunk/continuum-webapp/src/main/mdo/view-models.mdo?rev=775961&r1=775960&r2=775961&view=diff
>>
>> ==============================================================================
>> --- continuum/trunk/continuum-webapp/src/main/mdo/view-models.mdo
>> (original)
>> +++ continuum/trunk/continuum-webapp/src/main/mdo/view-models.mdo Mon May
>> 18 14:07:51 2009
>> @@ -262,7 +262,7 @@
>>          <required>true</required>
>>          <description>number of successful builds in the project
>> group</description>
>>          <type>int</type>
>> -          <defaultValue>-1</defaultValue>
>> +          <defaultValue>0</defaultValue>
>>        </field>
>>        <field>
>>          <name>numFailures</name>
>> @@ -270,7 +270,7 @@
>>          <required>true</required>
>>          <description>number of failed builds in the project
>> group</description>
>>          <type>int</type>
>> -          <defaultValue>-1</defaultValue>
>> +          <defaultValue>0</defaultValue>
>>        </field>
>>        <field>
>>          <name>numErrors</name>
>> @@ -278,7 +278,7 @@
>>          <required>true</required>
>>          <description>number of errored builds in the project
>> group</description>
>>          <type>int</type>
>> -          <defaultValue>-1</defaultValue>
>> +          <defaultValue>0</defaultValue>
>>        </field>
>>        <field>
>>          <name>repositoryId</name>
>>
>>
>>
> I'm not sure how this is relevant to the change? Does this change have any
> other impact?
>

Other classes that uses this class also sets the initial values of these
fields to 0 so no impact.

>
> - Brett
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message