Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 99579 invoked from network); 12 Apr 2009 01:49:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Apr 2009 01:49:20 -0000 Received: (qmail 79312 invoked by uid 500); 12 Apr 2009 01:49:20 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 79223 invoked by uid 500); 12 Apr 2009 01:49:20 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 79213 invoked by uid 99); 12 Apr 2009 01:49:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Apr 2009 01:49:20 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of marica.tan@gmail.com designates 74.125.44.158 as permitted sender) Received: from [74.125.44.158] (HELO yx-out-1718.google.com) (74.125.44.158) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Apr 2009 01:49:13 +0000 Received: by yx-out-1718.google.com with SMTP id 34so929790yxf.50 for ; Sat, 11 Apr 2009 18:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=o1paDDl/HJZkWjW55EyR+iXaW3klidT3V9jIzy04iyQ=; b=U456aeogqzK+qGznxF4kQbPAmIgCbgi2hfgYatDjWq3PJjp0qBMgxur6SBxcPjokF2 +93mAdH5Nr77EkHX/qE5CvoFXpMQ4+QFLKMCw+MD8N3ymzBQVT+mSt00d0lIEjb6JCfr 8VPGeBHazZrCHVuZR8zmEPMPRh6bJ0VdZF3Vs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=hVkCuDAu/JtPj4FQAsKcaxe7c1SlJxFFb8CPLbTtvp+3YBv9QPi27glC30I73lH13a RKIpnWNRjP4QUFrn/0dqb/XHWgwbtx7nVI2QOykWSRjDpXwPHeq1QXWE/XEkSS3BWHly h+EFlY0VulVcUjCDkusEfRlWq1YGwveyQJYSg= MIME-Version: 1.0 Received: by 10.150.133.18 with SMTP id g18mr9849024ybd.71.1239500932514; Sat, 11 Apr 2009 18:48:52 -0700 (PDT) In-Reply-To: References: Date: Sun, 12 Apr 2009 09:48:52 +0800 Message-ID: Subject: Re: svn commit: r759817 - in /continuum/trunk: continuum-data-management/data-management-jdo/src/main/java/org/apache/maven/continuum/management/ continuum-data-management/data-management-jdo/src/test/resources/ continuum-store/src/test/java/org/apac From: Marica Tan To: dev@continuum.apache.org Content-Type: multipart/alternative; boundary=000e0cd48564c805ec046751ccce X-Virus-Checked: Checked by ClamAV on apache.org --000e0cd48564c805ec046751ccce Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Linked this to [CONTINUUM-2106] and [CONTINUUM-2140] Thanks Wendy! -- Marica On Sun, Apr 12, 2009 at 12:39 AM, Wendy Smoak wrote: > Does this belong to an existing JIRA issue or does it need a new one? > I can open it and/or link things up if you provide a summary of what > this fixed. Thanks, -Wendy > > On Sun, Mar 29, 2009 at 5:59 PM, wrote: > > Author: ctan > > Date: Mon Mar 30 00:59:58 2009 > > New Revision: 759817 > > > > URL: http://svn.apache.org/viewvc?rev=759817&view=rev > > Log: > > some more fixes in data management tool > > > > Modified: > > > continuum/trunk/continuum-data-management/data-management-jdo/src/main/java/org/apache/maven/continuum/management/JdoDataManagementTool.java > > > continuum/trunk/continuum-data-management/data-management-jdo/src/test/resources/expected.xml > > > continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/AbstractContinuumStoreTestCase.java > > > continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/ContinuumStoreTest.java > > > > Modified: > continuum/trunk/continuum-data-management/data-management-jdo/src/main/java/org/apache/maven/continuum/management/JdoDataManagementTool.java > > URL: > http://svn.apache.org/viewvc/continuum/trunk/continuum-data-management/data-management-jdo/src/main/java/org/apache/maven/continuum/management/JdoDataManagementTool.java?rev=759817&r1=759816&r2=759817&view=diff > > > ============================================================================== > > --- > continuum/trunk/continuum-data-management/data-management-jdo/src/main/java/org/apache/maven/continuum/management/JdoDataManagementTool.java > (original) > > +++ > continuum/trunk/continuum-data-management/data-management-jdo/src/main/java/org/apache/maven/continuum/management/JdoDataManagementTool.java > Mon Mar 30 00:59:58 2009 > > @@ -257,6 +257,7 @@ > > Map buildQueues = new HashMap BuildQueue>(); > > for ( BuildQueue buildQueue : > (List)database.getBuildQueues() ) > > { > > + buildQueue = (BuildQueue) PlexusJdoUtils.addObject( > pmf.getPersistenceManager(), buildQueue ); > > buildQueues.put( buildQueue.getId(), buildQueue ); > > } > > > > @@ -408,6 +409,25 @@ > > releaseResult.setProjectGroup( projectGroups.get( > > Integer.valueOf( > releaseResult.getProjectGroup().getId() ) ) ); > > > > + ProjectGroup group = releaseResult.getProjectGroup(); > > + > > + for ( Project project : (List) group.getProjects() > ) > > + { > > + if ( project.getId() == > releaseResult.getProject().getId() ) > > + { > > + try > > + { > > + Project proj = > > + (Project) PlexusJdoUtils.getObjectById( > pmf.getPersistenceManager(), Project.class, project.getId(), null ); > > + releaseResult.setProject( proj ); > > + } > > + catch ( Exception e ) > > + { > > + throw new DataManagementException( e ); > > + } > > + } > > + } > > + > > releaseResult = > > (ContinuumReleaseResult) PlexusJdoUtils.addObject( > pmf.getPersistenceManager(), releaseResult ); > > } > > @@ -466,6 +486,7 @@ > > { > > buildQueues.add( allBuildQueues.get( Integer.valueOf( > buildQueue.getId() ) ) ); > > } > > + > > return buildQueues; > > } > > } > > > > Modified: > continuum/trunk/continuum-data-management/data-management-jdo/src/test/resources/expected.xml > > URL: > http://svn.apache.org/viewvc/continuum/trunk/continuum-data-management/data-management-jdo/src/test/resources/expected.xml?rev=759817&r1=759816&r2=759817&view=diff > > > ============================================================================== > > --- > continuum/trunk/continuum-data-management/data-management-jdo/src/test/resources/expected.xml > (original) > > +++ > continuum/trunk/continuum-data-management/data-management-jdo/src/test/resources/expected.xml > Mon Mar 30 00:59:58 2009 > > @@ -455,6 +455,7 @@ > > 2 > > cronExpression2 > > > > + > > > > > > > > > > Modified: > continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/AbstractContinuumStoreTestCase.java > > URL: > http://svn.apache.org/viewvc/continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/AbstractContinuumStoreTestCase.java?rev=759817&r1=759816&r2=759817&view=diff > > > ============================================================================== > > --- > continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/AbstractContinuumStoreTestCase.java > (original) > > +++ > continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/AbstractContinuumStoreTestCase.java > Mon Mar 30 00:59:58 2009 > > @@ -312,6 +312,7 @@ > > testSchedule1.addBuildQueue( buildQueue2 ); > > > > testSchedule2 = createTestSchedule( "name2", "description2", 2, > "cronExpression2", true ); > > + testSchedule2.addBuildQueue( buildQueue2 ); > > testSchedule2.addBuildQueue( buildQueue3 ); > > > > testSchedule3 = createTestSchedule( "name3", "description3", 3, > "cronExpression3", true ); > > > > Modified: > continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/ContinuumStoreTest.java > > URL: > http://svn.apache.org/viewvc/continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/ContinuumStoreTest.java?rev=759817&r1=759816&r2=759817&view=diff > > > ============================================================================== > > --- > continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/ContinuumStoreTest.java > (original) > > +++ > continuum/trunk/continuum-store/src/test/java/org/apache/maven/continuum/store/ContinuumStoreTest.java > Mon Mar 30 00:59:58 2009 > > @@ -372,8 +372,9 @@ > > > > schedule = (Schedule) schedules.get( 1 ); > > assertScheduleEquals( testSchedule2, schedule ); > > - assertEquals( "check size of buildQueues", 1, > schedule.getBuildQueues().size() ); > > - assertBuildQueueEquals( buildQueue3, (BuildQueue) > schedule.getBuildQueues().get( 0 ) ); > > + assertEquals( "check size of buildQueues", 2, > schedule.getBuildQueues().size() ); > > + assertBuildQueueEquals( buildQueue2, (BuildQueue) > schedule.getBuildQueues().get( 0 ) ); > > + assertBuildQueueEquals( buildQueue3, (BuildQueue) > schedule.getBuildQueues().get( 1 ) ); > > > > schedule = (Schedule) schedules.get( 2 ); > > assertScheduleEquals( testSchedule3, schedule ); > > > > > > > --000e0cd48564c805ec046751ccce--