continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wendy Smoak <wsm...@gmail.com>
Subject Re: svn commit: r709300 [2/3] - in /continuum/trunk: continuum-api/src/main/java/org/apache/continuum/dao/ continuum-api/src/main/java/org/apache/continuum/purge/ continuum-api/src/main/java/org/apache/continuum/taskqueue/ continuum-api/src/main/java
Date Sat, 28 Feb 2009 03:41:42 GMT
On Thu, Feb 26, 2009 at 8:04 PM, Marica Tan <ctan@exist.com> wrote:
> On Fri, Feb 27, 2009 at 2:25 AM, Wendy Smoak <wsmoak@gmail.com> wrote:
>
>> After upgrading to 1.3.x, I'm getting notification emails with the subject
>> line:
>>
>> [continuum] PREPARE BUILD SUCCESSFUL: ${projectScmRoot.scmRootAddress}
>>
>> Other than the subject, the notification looks the same as we used to
>> get for normal scheduled builds.  We did enable parallel builds after
>> upgrading.  Given that, what would have changed wrt notifications?
>> What does "PREPARE" mean here?
>>
>
> Since i separated the preparation of build ( cleaning of directory, updating
> ) from the actual build, that's what PREPARE means, which now seems
> confusing. Any suggestions?

The notification looked to me like it was for the actual build, not
just for preparing it.  There is still only one notification per
build, correct?

>> This seems to be hard coded in MailContinuumNotifier.java, and was
>> added below in the merge from the transient state branch.  Previously,
>> the subject was configurable in
>>        ./apps/continuum/WEB-INF/classes/META-INF/plexus/application.xml
>> with
>>        <subject-format>[continuum] BUILD ${state}:
>> ${project.projectGroup.name} - ${project.name} -
>> ${build.buildDefinition.description}</subject-format>
>> .
>>
>> It seems like either the projectScmRoot.scmRootAddress is not getting
>> populated on an upgrade from 1.2.x, or that's not the correct
>> expression.  In the log files I see a Velocity warning that
>> subjectPattern ${projectScmRoot.scmRootAddress} is not a valid
>> reference.
>>
>> Any ideas?
>
> Hmm i need to look more into this. Could you create an issue for this ?

Done. http://jira.codehaus.org/browse/CONTINUUM-2102

Thanks,
-- 
Wendy

Mime
View raw message