continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olivier Lamy" <ol...@apache.org>
Subject Re: [VOTE] Release Apache Continuum 1.2.1
Date Tue, 28 Oct 2008 08:06:01 GMT
Try with this at the end :

        // one email
        assertEquals( 1, mailSender.getReceivedEmails().size() );

        // two recipients
        assertEquals( 2, mailSender.getReceivedEmails().get( 0
).getRecipients( Message.RecipientType.TO ).length );

--
Olivier

2008/10/28 Wendy Smoak <wsmoak@gmail.com>:
> On Mon, Oct 27, 2008 at 3:52 PM, Olivier Lamy <olamy@apache.org> wrote:
>> My vote here is +0 (I don't want to block a release but it looks to me
>> as a regression and the fix has been committed)
>
> Hi Olivier.  It's no problem to do a 1.2.2, but I'd like to have a
> test for your change first.
>
> After chatting with you on irc I gave it a try involving lots of copy
> and paste, but my test always fails saying that only one email was
> received when two were expected. :(
> http://wiki.wsmoak.net/cgi-bin/wiki.pl?MailContinuumNotifierTest
>
> I updated the commit log messages on r708339 (branch) and r708342
> (trunk) to mention CONTINUUM-1944, which I opened (and closed) for
> this problem.
>
> And because I always forget how to do this...
>
> $ svn log -r708341:708342
> ------------------------------------------------------------------------
> r708342 | olamy | 2008-10-27 14:58:37 -0700 (Mon, 27 Oct 2008) | 1 line
>
> merge -r708338:708339 from 1.2.x branch
> ------------------------------------------------------------------------
>
> $ svn propset -r708342 --revprop svn:log "[CONTINUUM-1944] fix
> multiple notifiers element declaration in pom. merged -r708338:708339
> from 1.2.x branch."
> property 'svn:log' set on repository revision 708342
>
> Thanks,
> --
> Wendy
>

Mime
View raw message