continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rahul Thakur <rahul.thakur.x...@gmail.com>
Subject Re: which jpa branch is active?
Date Tue, 16 Sep 2008 20:18:17 GMT
Ken Liu wrote:
> I took some time over the weekend to look at the two branches. IMHO the
> approach used in the jpa-evenisse branch is more of a typical approach to
> using JPA and is basically the approach I would take.
>
> I can't quite grok the code in the other branch - I don't see the motivation
> for creating a Query abstraction, either.
>    
Abstracting the Query in that manner keeps the store API compact yet 
flexible enough to query entities based on various criteria.

Rahul

> Ken
>
> On Sat, Sep 13, 2008 at 1:30 AM, Emmanuel Venisse<
> emmanuel.venisse@gmail.com>  wrote:
>
>    
>> On Fri, Sep 12, 2008 at 9:46 PM, Wendy Smoak<wsmoak@gmail.com>  wrote:
>>
>>      
>>> On Fri, Sep 12, 2008 at 2:04 AM, Emmanuel Venisse
>>> <emmanuel.venisse@gmail.com>  wrote:
>>>        
>>>> On Fri, Sep 12, 2008 at 6:58 AM, Rahul Thakur
>>>>          
>>>>> Emmanuel, I am not sure I understand - where did you find sql in the
>>>>> code? I think we have discussed the approached a few times on this
>>>>> list but your comment above sounds like you didn't quite grasp the
>>>>> motivation behind it.
>>>>>            
>>>> Not sql but JPQL. For example in toString method in
>>>>
>>>>          
>> https://svn.apache.org/repos/asf/continuum/branches/continuum-jpa/continuum-model-jpa/src/main/java/org/apache/maven/continuum/store/jpa/ProjectGroupQuery.java
>>      
>>>> You're probably right, I don't grasp the motivation and I don't really
>>>>          
>>> like
>>>        
>>>> all string concatenations in toString() methods.
>>>>          
>>> Emmanuel, can you link to the equivalent (or a similar) query on your
>>> branch so we can see how it compares?
>>>        
>> In my branch, I use @NamedQueries annotations on the class, for example:
>>
>>
>> http://svn.apache.org/repos/asf/continuum/branches/continuum-jpa-evenisse/src/main/java/org/apache/continuum/model/project/ProjectGroup.java
>>
>> http://svn.apache.org/repos/asf/continuum/branches/continuum-jpa-evenisse/src/main/java/org/apache/continuum/model/project/Project.java
>>
>>
>>      
>>> Thanks,
>>> --
>>> Wendy
>>>
>>>        
>
>    



Mime
View raw message