From dev-return-7062-apmail-continuum-dev-archive=continuum.apache.org@continuum.apache.org Mon Jun 30 13:13:21 2008
Return-Path: <dev-return-7062-apmail-continuum-dev-archive=continuum.apache.org@continuum.apache.org>
Delivered-To: apmail-continuum-dev-archive@www.apache.org
Received: (qmail 35972 invoked from network); 30 Jun 2008 13:13:21 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 30 Jun 2008 13:13:21 -0000
Received: (qmail 86587 invoked by uid 500); 30 Jun 2008 13:13:22 -0000
Delivered-To: apmail-continuum-dev-archive@continuum.apache.org
Received: (qmail 86527 invoked by uid 500); 30 Jun 2008 13:13:22 -0000
Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@continuum.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@continuum.apache.org>
List-Post: <mailto:dev@continuum.apache.org>
List-Id: <dev.continuum.apache.org>
Reply-To: dev@continuum.apache.org
Delivered-To: mailing list dev@continuum.apache.org
Received: (qmail 86497 invoked by uid 99); 30 Jun 2008 13:13:22 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jun 2008 06:13:22 -0700
X-ASF-Spam-Status: No, hits=1.2 required=10.0
	tests=SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received: from [210.50.76.235] (HELO mx06.syd.iprimus.net.au) (210.50.76.235)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jun 2008 13:12:28 +0000
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AqUAANF3aEjKQ1aR/2dsb2JhbAAIsCQ
X-IronPort-AV: E=Sophos;i="4.27,727,1204462800"; 
   d="scan'208";a="126965224"
Received: from unknown (HELO [172.18.237.213]) ([202.67.86.145])
  by smtp06.syd.iprimus.net.au with ESMTP; 30 Jun 2008 23:11:44 +1000
Message-Id: <6E4215C5-0CC9-4DFF-8ACB-B2B255A9CD01@apache.org>
From: Brett Porter <brett@apache.org>
To: dev@continuum.apache.org
In-Reply-To: <9948cb690806300556q64baf9dp9e0bb60e32b749ff@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v924)
Subject: Re: svn commit: r672050 - in /continuum/trunk: ./ continuum-api/ continuum-api/src/main/java/org/apache/maven/continuum/configuration/ continuum-base/continuum-scm/ continuum-commons/src/main/java/org/apache/maven/continuum/utils/ continuum-configura
Date: Mon, 30 Jun 2008 23:11:43 +1000
References: <9948cb690806300556q64baf9dp9e0bb60e32b749ff@mail.gmail.com>
X-Mailer: Apple Mail (2.924)
X-Virus-Checked: Checked by ClamAV on apache.org


On 30/06/2008, at 10:56 PM, Olivier Lamy wrote:

> 2008/6/30 Brett Porter <brett@apache.org>:
>> Hi Olivier,
>>
>> The new config looks good to me :)
>>
>> Did I understand correctly that we will be able to port from the old
>> database config to the new one through the model?
>>
>> Quick thoughts/questions...
>>
>> On 27/06/2008, at 8:53 AM, olamy@apache.org wrote:
>>
>>> +    <dependency>
>>> +      <groupId>org.apache.continuum</groupId>
>>> +      <artifactId>continuum-api</artifactId>
>>> +    </dependency>
>>
>> Not sure why -configuration needs the rest of the API? Isn't this  
>> passed
>> into the API?
>
> Because I have added beans in continuum-api.
> But you're rigth they could be in the continuum-configuration module.
> Do we have to move this module to continuum-base ?

I think that makes sense. Thanks!

>
>
>>
>>>
>>> Added:
>>> continuum/trunk/continuum-configuration/src/main/resources/META- 
>>> INF/continuum/continuum-configuration.xml
>>> URL:
>>> http://svn.apache.org/viewvc/continuum/trunk/continuum-configuration/src/main/resources/META-INF/continuum/continuum-configuration.xml?rev=672050&view=auto
>>>
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> = 
>>> ====================================================================
>>> ---
>>> continuum/trunk/continuum-configuration/src/main/resources/META- 
>>> INF/continuum/continuum-configuration.xml
>>> (added)
>>> +++
>>> continuum/trunk/continuum-configuration/src/main/resources/META- 
>>> INF/continuum/continuum-configuration.xml
>>> Thu Jun 26 15:53:16 2008
>>> @@ -0,0 +1,29 @@
>>> +<?xml version="1.0"?>
>>> +
>>> +<!--
>>> +  ~ Licensed to the Apache Software Foundation (ASF) under one
>>> +  ~ or more contributor license agreements.  See the NOTICE file
>>> +  ~ distributed with this work for additional information
>>> +  ~ regarding copyright ownership.  The ASF licenses this file
>>> +  ~ to you under the Apache License, Version 2.0 (the
>>> +  ~ "License"); you may not use this file except in compliance
>>> +  ~ with the License.  You may obtain a copy of the License at
>>> +  ~
>>> +  ~   http://www.apache.org/licenses/LICENSE-2.0
>>> +  ~
>>> +  ~ Unless required by applicable law or agreed to in writing,
>>> +  ~ software distributed under the License is distributed on an
>>> +  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>>> +  ~ KIND, either express or implied.  See the License for the
>>> +  ~ specific language governing permissions and limitations
>>> +  ~ under the License.
>>> +  -->
>>> +
>>> +<configuration>
>>> +  <system/>
>>> +  <jndi prefix="java:comp/env" config-optional="true"/>
>>> +  <xml fileName="${appserver.base}/conf/continuum.xml"
>>> config-optional="true"
>>> +       config-forceCreate="true" config- 
>>> name="org.apache.continuum"/>
>>> +  <xml fileName="${user.home}/.m2/continuum.xml" config- 
>>> optional="true"
>>> +       config-forceCreate="true"
>>> config-name="org.apache.continuum.user"/>
>>> +</configuration>
>>> \ No newline at end of file
>>
>> Should this be in the webapp/bundle, rather than baked into the JAR?
>
> Oh Yes, sure .
>
>>
>> Cheers,
>> Brett
>>
>> --
>> Brett Porter
>> brett@apache.org
>> http://blogs.exist.com/bporter/
>>
>>

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/