continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Venisse" <emmanuel.veni...@gmail.com>
Subject Re: svn commit: r670751 - in /continuum/trunk: continuum-api/src/main/java/org/apache/maven/continuum/execution/ continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/ continuum-core/src/main/java/org/apache/maven/continuum/executio
Date Tue, 24 Jun 2008 09:25:05 GMT
On Tue, Jun 24, 2008 at 10:47 AM, Brett Porter <brett@apache.org> wrote:

> cool!
>
> one question, one nitpick:
>
> On 24/06/2008, at 4:59 AM, evenisse@apache.org wrote:
>
>
>> +        // Check changes
>> +        if ( !shouldBuild &&
>> !context.getScmResult().getChanges().isEmpty() )
>> +        {
>> +            try
>> +            {
>> +                ContinuumBuildExecutor executor =
>> buildExecutorManager.getBuildExecutor( project.getExecutorId() );
>> +                shouldBuild = executor.shouldBuild(
>> context.getScmResult().getChanges(), project,
>> +
>>  workingDirectoryService.getWorkingDirectory( project ),
>> +
>>  context.getBuildDefinition() );
>> +            }
>> +            catch ( Exception e )
>> +            {
>> +                //nothing to do
>> +            }
>> +        }
>>
>
> it's not clear to me why the exception can be swallowed?


Fixed.


>
>
>> +        int i = 0;
>> +        while ( i <= files.size() - 1 )
>> +        {
>> +            ChangeFile file = files.get( i );
>> +            boolean found = false;
>> +            for ( String module : modules )
>> +            {
>> +                if ( file.getName().indexOf( module ) > 0 )
>> +                {
>> +                    files.remove( file );
>> +                    found = true;
>> +                    break;
>> +                }
>> +            }
>> +            if ( !found )
>> +            {
>> +                i++;
>> +            }
>> +            else
>> +            {
>> +                break;
>> +            }
>> +        }
>>
>
> can't the i stuff be a standard for loop?


What do you mean?
I can't use a 'for' loop for the i stuff because in this loop I remove some
file in the list.

Emmanuel

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message