continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Olivier Lamy" <ol...@apache.org>
Subject Re: svn commit: r672050 - in /continuum/trunk: ./ continuum-api/ continuum-api/src/main/java/org/apache/maven/continuum/configuration/ continuum-base/continuum-scm/ continuum-commons/src/main/java/org/apache/maven/continuum/utils/ continuum-configura
Date Mon, 30 Jun 2008 12:56:00 GMT
2008/6/30 Brett Porter <brett@apache.org>:
> Hi Olivier,
>
> The new config looks good to me :)
>
> Did I understand correctly that we will be able to port from the old
> database config to the new one through the model?
>
> Quick thoughts/questions...
>
> On 27/06/2008, at 8:53 AM, olamy@apache.org wrote:
>
>> +    <dependency>
>> +      <groupId>org.apache.continuum</groupId>
>> +      <artifactId>continuum-api</artifactId>
>> +    </dependency>
>
> Not sure why -configuration needs the rest of the API? Isn't this passed
> into the API?

Because I have added beans in continuum-api.
But you're rigth they could be in the continuum-configuration module.
Do we have to move this module to continuum-base ?

>
>>
>> Added:
>> continuum/trunk/continuum-configuration/src/main/resources/META-INF/continuum/continuum-configuration.xml
>> URL:
>> http://svn.apache.org/viewvc/continuum/trunk/continuum-configuration/src/main/resources/META-INF/continuum/continuum-configuration.xml?rev=672050&view=auto
>>
>> ==============================================================================
>> ---
>> continuum/trunk/continuum-configuration/src/main/resources/META-INF/continuum/continuum-configuration.xml
>> (added)
>> +++
>> continuum/trunk/continuum-configuration/src/main/resources/META-INF/continuum/continuum-configuration.xml
>> Thu Jun 26 15:53:16 2008
>> @@ -0,0 +1,29 @@
>> +<?xml version="1.0"?>
>> +
>> +<!--
>> +  ~ Licensed to the Apache Software Foundation (ASF) under one
>> +  ~ or more contributor license agreements.  See the NOTICE file
>> +  ~ distributed with this work for additional information
>> +  ~ regarding copyright ownership.  The ASF licenses this file
>> +  ~ to you under the Apache License, Version 2.0 (the
>> +  ~ "License"); you may not use this file except in compliance
>> +  ~ with the License.  You may obtain a copy of the License at
>> +  ~
>> +  ~   http://www.apache.org/licenses/LICENSE-2.0
>> +  ~
>> +  ~ Unless required by applicable law or agreed to in writing,
>> +  ~ software distributed under the License is distributed on an
>> +  ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>> +  ~ KIND, either express or implied.  See the License for the
>> +  ~ specific language governing permissions and limitations
>> +  ~ under the License.
>> +  -->
>> +
>> +<configuration>
>> +  <system/>
>> +  <jndi prefix="java:comp/env" config-optional="true"/>
>> +  <xml fileName="${appserver.base}/conf/continuum.xml"
>> config-optional="true"
>> +       config-forceCreate="true" config-name="org.apache.continuum"/>
>> +  <xml fileName="${user.home}/.m2/continuum.xml" config-optional="true"
>> +       config-forceCreate="true"
>> config-name="org.apache.continuum.user"/>
>> +</configuration>
>> \ No newline at end of file
>
> Should this be in the webapp/bundle, rather than baked into the JAR?

Oh Yes, sure .

>
> Cheers,
> Brett
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>

Mime
View raw message