continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r670751 - in /continuum/trunk: continuum-api/src/main/java/org/apache/maven/continuum/execution/ continuum-core/src/main/java/org/apache/maven/continuum/buildcontroller/ continuum-core/src/main/java/org/apache/maven/continuum/execution/ con...
Date Tue, 24 Jun 2008 08:47:44 GMT
cool!

one question, one nitpick:

On 24/06/2008, at 4:59 AM, evenisse@apache.org wrote:

>
> +        // Check changes
> +        if ( !shouldBuild && ! 
> context.getScmResult().getChanges().isEmpty() )
> +        {
> +            try
> +            {
> +                ContinuumBuildExecutor executor =  
> buildExecutorManager.getBuildExecutor( project.getExecutorId() );
> +                shouldBuild =  
> executor.shouldBuild( context.getScmResult().getChanges(), project,
> +                                                     
> workingDirectoryService.getWorkingDirectory( project ),
> +                                                     
> context.getBuildDefinition() );
> +            }
> +            catch ( Exception e )
> +            {
> +                //nothing to do
> +            }
> +        }

it's not clear to me why the exception can be swallowed?
>
> +        int i = 0;
> +        while ( i <= files.size() - 1 )
> +        {
> +            ChangeFile file = files.get( i );
> +            boolean found = false;
> +            for ( String module : modules )
> +            {
> +                if ( file.getName().indexOf( module ) > 0 )
> +                {
> +                    files.remove( file );
> +                    found = true;
> +                    break;
> +                }
> +            }
> +            if ( !found )
> +            {
> +                i++;
> +            }
> +            else
> +            {
> +                break;
> +            }
> +        }

can't the i stuff be a standard for loop?

Cheers,
Brett

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


Mime
View raw message