Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@continuum.apache.org
Received-SPF: pass (athena.apache.org: domain of oliver.lamy@gmail.com
 designates 209.85.200.170 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=IcMJX0gZh2nUbZY5Ce9z6r6inb51ZncZxvXSsoV8S4mQfrZN49mXfxxVFuwwXNjDNNh52Wag+SRDy7iWT+/2xEx3OvyUDOkI394lBkMnbD6ultMBjGQblveFK6deeOtKlkJU+0SPI0WyP4Yp8uxeov7DZZhRhBptXkUr/DV36Fo=
Message-ID: <9948cb690805061546v423dc23at3f9b68c2eae535d2@mail.gmail.com>
Date: Wed, 7 May 2008 00:46:13 +0200
From: "Olivier Lamy" <olamy@apache.org>
Sender: oliver.lamy@gmail.com
To: dev@continuum.apache.org
Subject: Re: refactoring the SCM
In-Reply-To: <F39C7641-930A-4621-8C7B-B34CDCB95BA6@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <3AD39409-CACE-4134-A481-5775E8B0DA30@apache.org>
	 <9948cb690804291452q584638d2wb84a032d853bfa90@mail.gmail.com>
	 <3AC8634F-4704-4C76-86A1-EC76BA94FFFC@apache.org>
	 <F39C7641-930A-4621-8C7B-B34CDCB95BA6@apache.org>

Hi,
Looks fine.
Thanks,
--
Olivier

2008/5/6 Brett Porter <brett@apache.org>:
> ok, fixed and committed :)
>
>  Anyone able to take a look through?
>
>  Cheers,
>  Brett
>
>
>
>  On 02/05/2008, at 2:53 PM, Brett Porter wrote:
>
>
> > me too after cleaning up. Sorry about that, I'll look into it.
> >
> > - Brett
> >
> > On 30/04/2008, at 5:52 AM, Olivier Lamy wrote:
> >
> >
> > > Hi,
> > > I can't build the branch :
> > >
> /local/olamy/open-source/continuum-svn/builder-branch/continuum-core/src/main/java/org/apache/maven/continuum/core/action/AddProjectToCheckOutQueueAction.java:[60,16]
> > > cannot find symbol
> > > symbol  : class CheckOutTask
> > > location: class
> > > org.apache.maven.continuum.core.action.AddProjectToCheckOutQueueAction
> > >
> > >
> > > 2008/4/27 Brett Porter <brett@apache.org>:
> > >
> > > > Hi,
> > > >
> > > > I've started to do some refactoring - this is along the way to the
> builder
> > > > separation I mentioned earlier.
> > > >
> > > > If you have a moment, please review r 651947. It's on a branch, but
> I'd
> > > > like to regularly merge to trunk if there are no objects to avoid
> getting
> > > > too distant. I have more tests to write for this first.
> > > >
> > > > All I've done is pulled the DefaultContinuumScm class out into a
> separate
> > > > module, and decoupled it from the model. It already contained some
> logic
> > > > related to the SCMs (which may actually need to go back into Maven SCM
> > > > itself). I pulled the logging and database updates back into the
> actions in
> > > > code (this did result in some duplication, but I can clean that up
> later).
> > > > It also showed that some code was never having its results used, and
> also
> > > > started to expose some exception handling bugs. I stopped wrapping
> > > > exceptions and results, choosing to use the Maven SCM API natively.
> > > >
> > > > Thoughts?
> > > >
> > > > Anyone that is knowledgable in Spring, please check my work :) Is
> there a
> > > > way to easily populate maps of beans, instead of hard coding the
> providers?
> > > >
> > > >
> > >
> > > hehe it looks plexus have some nice features ;-)
> > >
> > >
> > > > Cheers,
> > > > Brett
> > > >
> > > > --
> > > > Brett Porter
> > > > brett@apache.org
> > > > http://blogs.exist.com/bporter/
> > > >
> > > >
> > > >
> > >
> >
> > --
> > Brett Porter
> > brett@apache.org
> > http://blogs.exist.com/bporter/
> >
> >
>
>  --
>  Brett Porter
>  brett@apache.org
>  http://blogs.exist.com/bporter/
>
>