Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 57248 invoked from network); 5 May 2008 23:06:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 May 2008 23:06:08 -0000 Received: (qmail 39215 invoked by uid 500); 5 May 2008 23:06:09 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 39177 invoked by uid 500); 5 May 2008 23:06:09 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 39166 invoked by uid 99); 5 May 2008 23:06:09 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 May 2008 16:06:09 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 124.108.96.112 is neither permitted nor denied by domain of rahul.thakur.xdev@gmail.com) Received: from [124.108.96.112] (HELO rel105.mail.aue.yahoo.com) (124.108.96.112) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 05 May 2008 23:05:14 +0000 Received: (qmail 62632 invoked by uid 1000); 5 May 2008 23:04:47 -0000 Received: from 124.108.96.73 by rel105.mail.aue.yahoo.com with SMTP; Mon, 05 May 2008 16:04:47 -0700 Received: (qmail 39459 invoked from network); 5 May 2008 23:04:47 -0000 Received: from unknown (HELO ?192.168.103.153?) (rahul.thakur@xtra.co.nz@203.193.119.196 with plain) by smtp104.tnz.mail.aue.yahoo.com with SMTP; 5 May 2008 23:04:47 -0000 X-YMail-OSG: .3Ocs5sVM1ldlFn_4prwf9bmn4IPHxpqcMBb0pjnThTrrhS6mNjp5A9MGUqho6FsOQ-- X-Yahoo-Newman-Property: ymail-3 Message-ID: <481F928D.6080900@gmail.com> Date: Tue, 06 May 2008 11:04:45 +1200 From: Rahul Thakur User-Agent: Thunderbird 3.0a1pre (Windows/2008041703) MIME-Version: 1.0 To: dev@continuum.apache.org Subject: Re: ContinuumStore refactoring References: <5d3354e30802211754y54625a60la19c64142c58e6bc@mail.gmail.com> <47BE99CB.7080607@gmail.com> <5d3354e30802271907x4541ba39g17a8a9b1cad0ba97@mail.gmail.com> <48169CBF.5030406@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Thanks Emmanuel, I will take a look this weekend (still trying to get system back to life after recent crash) . Cheers, Rahul Emmanuel Venisse wrote: > ok, the base is done. You can look at it. > > Team, can you look at my JPA branch and at the Rahul's one too and let us > know what you think about them and which method you'd want to use in > Continuum. > > Thanks > Emmanuel > > On Wed, Apr 30, 2008 at 6:19 AM, Emmanuel Venisse< > emmanuel.venisse@gmail.com> wrote: > >> The sample is ready, I'll try to clean the code in the train and commit it >> tonight. >> I wanted to use Spring annotations for auto-configuration instead of the >> sping conf file, but it isn't important and out of topic for the sample. >> >> Emmanuel >> >> >> On Tue, Apr 29, 2008 at 5:57 AM, Rahul Thakur >> wrote: >> >>> Hi Emmanuel, >>> >>> Just wondering if you hacked some samples? :-) >>> >>> Cheers, >>> Rahul >>> >>> >>> >>> >>> Emmanuel Venisse wrote: >>> >>>> I'll create some examples asap. >>>> >>>> Emmanuel >>>> >>>> On Thu, Feb 28, 2008 at 4:07 AM, Rahul Thakur< >>>> rahul.thakur.xdev@gmail.com> >>>> wrote: >>>> >>>> Hi, >>>>> Some code using a couple of Entities as examples would be nice :-) >>>>> >>>>> I still think the API would be verbose. >>>>> >>>>> Thanks, >>>>> Rahul >>>>> >>>>> >>>>> On Fri, Feb 22, 2008 at 11:06 PM, Emmanuel Venisse >>>>> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Fri, Feb 22, 2008 at 10:45 AM, Rahul Thakur< >>>>>> >>>>> rahul.thakur.xdev@gmail.com> >>>>> >>>>>> wrote: >>>>>> >>>>>>> 2) Criteria vs Named Queries: I am not convinced (yet) that >>>>>>>>> Named >>>>>>>>> queries are the way to go. I did some digging around, they >>>>>>>>> are >>>>>>>>> >>>>>>>> indeed >>>>>> best practices for JPA but I think the decision merits other >>>>>>>>> consideration(s). I still believe the Criteria Queries will >>>>>>>>> help us >>>>>>>>> define a cleaner Store interface. >>>>>>>>> >>>>>>>>> >>>>>>>> I'm always in favor of named queries. >>>>>>>> An other point about them that I haven't explain in previous >>>>>>>> threads >>>>>>>> >>>>>>> (I >>>>>> think) is that with named queries, it is possible to modify >>>>>>>> queries >>>>>>>> externally with xml files so if with a DB we have some >>>>>>>> performance >>>>>>>> >>>>>>> issues, >>>>>>> it will be possible to override queries by a modified JPQL query >>>>>>>> or >>>>>>>> >>>>>>> a >>>>>> native >>>>>> >>>>>>> query. >>>>>>>> How do you see the refactored ContinuumStore interface using >>>>>>> Named >>>>>>> Queries? I suspect it will be just as verbose again. >>>>>>> >>>>>> I don't want to see a new time a big class for the store part. it >>>>>> must >>>>>> >>>>> be >>>>> >>>>>> splitted in few domains. >>>>>> All named queries related to Project would be defined in the >>>>>> Project >>>>>> >>>>> class, >>>>> >>>>>> all named queries related to ProjectGroup would be defined in the >>>>>> ProjectGroup class... >>>>>> >>>>>> And we can add some more classes for particular results that >>>>>> aren't >>>>>> >>>>> entities >>>>> >>>>>> objects (we won't have a lot) >>>>>> >>>>>> With this, all concerns are separated and linked to a specific >>>>>> entity. >>>>>> >>>>> Easy >>>>> >>>>>> to code, easy to read, easy to understand. It's my opinion. >>>>>> >>>>>> Sorry, still not convinced ;-) >>>>>> I hope you are now ;-) >>>>>> >>>>>> Emmanuel >>>>>> >>>>>>> Rahul >>>>>>> >>>>>>> >