Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@continuum.apache.org
Received-SPF: pass (athena.apache.org: domain of carlossg@gmail.com designates
 209.85.198.246 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=RD+X+PoY5POoEQk80WVhHU1jKW4FknQpS0lrPizwY1kcCBt+hGoeQ3WfRh4ayUyLCIYY7239apAItsPKh1JHtxZ4WTvMXJRD0ExXceQg3Aan7shsReoX3Z4LZgAoHqugE7aGl0HdvtL8Yi9747shv5DKxpj07His6LaIFobuXHU=
Message-ID: <1a5b6c410805071407w5a390c02rb3c2dbf26ac5fefb@mail.gmail.com>
Date: Wed, 7 May 2008 14:07:02 -0700
From: "Carlos Sanchez" <carlos@apache.org>
Sender: carlossg@gmail.com
To: dev@continuum.apache.org
Subject: Re: refactoring the SCM
In-Reply-To: <3AD39409-CACE-4134-A481-5775E8B0DA30@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <3AD39409-CACE-4134-A481-5775E8B0DA30@apache.org>

I have just committed a solution to the map of beans.
Unfortunately is Spring-dependent so it may make sense to put it in a
separate continuum-spring module, maybe just in the future if there
are more support classes like it.

On Sun, Apr 27, 2008 at 7:02 AM, Brett Porter <brett@apache.org> wrote:
> Hi,
>
>  I've started to do some refactoring - this is along the way to the builder
> separation I mentioned earlier.
>
>  If you have a moment, please review r 651947. It's on a branch, but I'd
> like to regularly merge to trunk if there are no objects to avoid getting
> too distant. I have more tests to write for this first.
>
>  All I've done is pulled the DefaultContinuumScm class out into a separate
> module, and decoupled it from the model. It already contained some logic
> related to the SCMs (which may actually need to go back into Maven SCM
> itself). I pulled the logging and database updates back into the actions in
> code (this did result in some duplication, but I can clean that up later).
> It also showed that some code was never having its results used, and also
> started to expose some exception handling bugs. I stopped wrapping
> exceptions and results, choosing to use the Maven SCM API natively.
>
>  Thoughts?
>
>  Anyone that is knowledgable in Spring, please check my work :) Is there a
> way to easily populate maps of beans, instead of hard coding the providers?
>
>  Cheers,
>  Brett
>
>  --
>  Brett Porter
>  brett@apache.org
>  http://blogs.exist.com/bporter/
>
>


-- 
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
 -- The Princess Bride